From: "Zack Weinberg" <zack@owlfolio.org>
To: "Adhemerval Zanella" <adhemerval.zanella@linaro.org>,
"Joe Simmons-Talbott" <josimmon@redhat.com>,
bjoern.esser@gmail.com
Cc: "GNU libc development" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] crypt: Get rid of alloca usage in __sha256_crypt_r
Date: Wed, 20 Sep 2023 11:23:51 -0400 [thread overview]
Message-ID: <60a24b3c-4c43-4ba9-bd5a-dd88fc001ff4@app.fastmail.com> (raw)
In-Reply-To: <ea83b62f-1db7-4c7d-89f2-cadc2b4c297b@linaro.org>
On Tue, Sep 19, 2023, at 12:18 PM, Adhemerval Zanella Netto wrote:
> On 18/09/23 17:26, Joe Simmons-Talbott wrote:
>> Replace alloca usage with scratch_buffers to avoid potential stack
>> overflow.
> Would it possible to import libxcrypt code for sha256/sha512/md5 that
> already does not user alloca or malloc?
I would have no objection. I thought the plan was to delete libc's crypt altogether,
though? If that's slated to happen within the next couple of releases, it might be
less churn to take Joe's patch, or just to do the deletion now.
cc:ing Bjoern Esser in case he has an opinion.
zw
next prev parent reply other threads:[~2023-09-20 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 20:26 Joe Simmons-Talbott
2023-09-19 16:18 ` Adhemerval Zanella Netto
2023-09-20 15:23 ` Zack Weinberg [this message]
2023-09-21 12:59 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a24b3c-4c43-4ba9-bd5a-dd88fc001ff4@app.fastmail.com \
--to=zack@owlfolio.org \
--cc=adhemerval.zanella@linaro.org \
--cc=bjoern.esser@gmail.com \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).