From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 61D543858D1E for ; Thu, 27 Jan 2022 04:54:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61D543858D1E Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-227-PqUETrq_Py-T1eB0J82_Sw-1; Wed, 26 Jan 2022 23:54:19 -0500 X-MC-Unique: PqUETrq_Py-T1eB0J82_Sw-1 Received: by mail-io1-f72.google.com with SMTP id m185-20020a6bbcc2000000b00605898d6b61so1306096iof.17 for ; Wed, 26 Jan 2022 20:54:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=Q7erNk3AsE5kWHTVATxDA1WjUnAx2w2kJbMp3sUWswg=; b=6p1kSMp4zrUOBgopDIM4DkCOD/k/EaQh9xBipm5bC0MAIwntZQrYIamrpLGe3Sm6H7 8gSBwYPtIvTXvMtwxpctjF0Ctj5v4niVOf8ToCq0Ic5ri3KQ8/Q+kwzYg2j4A3V/6h4/ JT5XZX72lYV40yQoEWOXyynpogfcTJG8bPLt8mnbMylEtxIwYe0a1dlKQg/C91Lt0ytS ooYQ04xJANJs8e10y5Dm2zZcjf1co8Sv3RfBCgLnJ/M6/xyEI3V0rR7QJOrdKxa/9/36 Yq4dR9/0kdAc9/assuQ+ODEb7ibYEDXPByOjm/QTxEmJCjyJ36O+zJ0e40/eu8eGImkF yznA== X-Gm-Message-State: AOAM530CeHE8TWOCTVbLEwat5tA7QkCnRAmzJRpKMVmfp0hW9x6XBrwz DAByy6trIpT9WNHcaBMHYL9QQI/K3iXMQmlMejGzs7VKV6LhAZsRmylI6VJpbc+yON2zOAtTETw r2WT+0qn+Rqsv9ixzys8r X-Received: by 2002:a02:94e8:: with SMTP id x95mr1013833jah.20.1643259258338; Wed, 26 Jan 2022 20:54:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyeHs0oIbiM9Y8R8W+zo8TTgmRjIeGVtxbdap9r/7KghgPHQAivSVy93laW8Y3i1JGVyn59A== X-Received: by 2002:a02:94e8:: with SMTP id x95mr1013831jah.20.1643259258204; Wed, 26 Jan 2022 20:54:18 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id w4sm12224476ilv.32.2022.01.26.20.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 20:54:17 -0800 (PST) Message-ID: <60e40abc-136f-b09c-3c8d-dc35c01f967a@redhat.com> Date: Wed, 26 Jan 2022 23:54:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398] To: "H.J. Lu" , libc-alpha@sourceware.org References: <20220126205119.2000487-1-hjl.tools@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220126205119.2000487-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 04:54:24 -0000 On 1/26/22 15:51, H.J. Lu wrote: > HLE is disabled on blacklisted CPUs. Use CHECK_FEATURE_PRESENT, instead > of CHECK_FEATURE_ACTIVE, to check HLE. OK for glibc 2.35. Fixes the issue on my T590 with the resume issues. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > sysdeps/x86/tst-cpu-features-supports.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c > index 46b2c7bf83..9f10f02954 100644 > --- a/sysdeps/x86/tst-cpu-features-supports.c > +++ b/sysdeps/x86/tst-cpu-features-supports.c > @@ -130,7 +130,7 @@ do_test (int argc, char **argv) > fails += CHECK_FEATURE_ACTIVE (gfni, GFNI); > #endif > #if __GNUC_PREREQ (11, 0) > - fails += CHECK_FEATURE_ACTIVE (hle, HLE); > + fails += CHECK_FEATURE_PRESENT (hle, HLE); > fails += CHECK_FEATURE_PRESENT (ibt, IBT); > fails += CHECK_FEATURE_ACTIVE (lahf_lm, LAHF64_SAHF64); > fails += CHECK_FEATURE_PRESENT (lm, LM); -- Cheers, Carlos.