From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id 5D7B43858D39 for ; Wed, 6 Jul 2022 12:21:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D7B43858D39 Received: by mail-ua1-x92e.google.com with SMTP id s3so3506157uaq.2 for ; Wed, 06 Jul 2022 05:21:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=V+IVwakzcYLaViTLq1UD4b88ai0oJ+zWk3R4MSfUtnM=; b=Nsqu042jlqOWblw2nYFk5W3FTCjYwG8W0NsQSHoSjJR5k7Pl1D2N1WvWquh0bkBt+5 r3Kp/HgyCHWV5cz/+Co9pEEffswaB7iU7WHOiPf+XCAF5Wn1Kao1xziE24xzIJpDheVK VWvueg+I5LdYVBx6VX5Jj++lenj71no77Eh+C8vGTVOypSDChx96siVPbEKzrLhfQcGZ NjMy+3qRb9wrJLYwZ7+Xx8I0xHDr5AhHNAyHZQG91acRdY45IQAbwTaG72iLe3Jf2Sjt fQZoLQQQK3mfON9tE3xyewvqwYdw6+hurV+v3ylsP5iXnKeSnZ7eg43c/c0tgfIEZuXA APYA== X-Gm-Message-State: AJIora81rXQhBZ3Jkkje8NOiVK6iziGZTVO81c5w7OVgiPDVblxIn+1M 94y8dZIyKqhwx9KZhgLuwZ94KJ6YVg5jucyI X-Google-Smtp-Source: AGRyM1tEOeBzfiQHUKGPyzIgeT/dKTiNaIxLD5oKyRpVaGMrqtB3Gatcm1xd6gJDWQEnE4fh2wy6tQ== X-Received: by 2002:ab0:7001:0:b0:382:c47c:2825 with SMTP id k1-20020ab07001000000b00382c47c2825mr4289745ual.23.1657110098696; Wed, 06 Jul 2022 05:21:38 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7cb:fef6:4d79:ffc6:5481:dcec]) by smtp.gmail.com with ESMTPSA id f1-20020ac5c5a1000000b0036bf02bf654sm8331655vkl.3.2022.07.06.05.21.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2022 05:21:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v7 5/5] linux: Add mount_setattr From: Adhemerval Zanella In-Reply-To: Date: Wed, 6 Jul 2022 09:21:32 -0300 Cc: Carlos O'Donell via Libc-alpha , Carlos O'Donell Content-Transfer-Encoding: quoted-printable Message-Id: <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-6-adhemerval.zanella@linaro.org> <0c64445d-a4f7-bb60-d165-e3c02d89549e@redhat.com> To: Andreas Schwab X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 12:21:40 -0000 > On 6 Jul 2022, at 06:25, Andreas Schwab wrote: >=20 > This is causing a conflict with , breaking the build of > gcc. >=20 > In file included from /usr/include/linux/fs.h:19, > from = ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.= cpp:76: > /usr/include/linux/mount.h:95:6: error: multiple definition of 'enum = fsconfig_command' > 95 | enum fsconfig_command { > | ^~~~~~~~~~~~~~~~ > In file included from = ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.= cpp:63: > /usr/include/sys/mount.h:189:6: note: previous definition here > 189 | enum fsconfig_command > | ^~~~~~~~~~~~~~~~ > /usr/include/linux/mount.h:129:8: error: redefinition of 'struct = mount_attr' > 129 | struct mount_attr { > | ^~~~~~~~~~ > /usr/include/sys/mount.h:161:8: note: previous definition of 'struct = mount_attr' > 161 | struct mount_attr > | ^~~~~~~~~~ > make[4]: *** [Makefile:617: sanitizer_platform_limits_posix.lo] Error = 1 I am not sure how to handle it, glibc sys/mount.h should be a standalone header. Maybe check if _UAPI_LINUX_MOUNT_H is defined so to use the kernel definition? Or check the kernel version and __has_include and use kernel version instead? >=20 > --=20 > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA = B9D7 > "And now for something completely different."