From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 3ECC63858005 for ; Wed, 3 Nov 2021 19:14:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ECC63858005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7417B1600CD; Wed, 3 Nov 2021 12:14:53 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UeXFWvyOC1qD; Wed, 3 Nov 2021 12:14:52 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D1EB41600D3; Wed, 3 Nov 2021 12:14:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yhRlsqsuT3n3; Wed, 3 Nov 2021 12:14:52 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B1C671600CD; Wed, 3 Nov 2021 12:14:52 -0700 (PDT) Message-ID: <61531402-fbc9-fcc9-93b9-f453901bf399@cs.ucla.edu> Date: Wed, 3 Nov 2021 12:14:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] tst-tzset: output reason when creating 4GiB file fails Content-Language: en-US To: Stafford Horne , GLIBC patches References: <20211102233159.4094554-1-shorne@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20211102233159.4094554-1-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 19:14:55 -0000 On 11/2/21 16:31, Stafford Horne via Libc-alpha wrote: > + { > + printf ("creating timezone file of size: %" PRId64 "MiB failed.\n", > + size / (1024 * 1024)); Why not simply print the size in bytes? Converting to MiB outputs less information due to rounding, and is hardly worth the trouble here. Other than that, looks fine.