Re: [PATCH v5 02/13] signal: Move sys_siglist to a compat symbol

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 02/07/2020 15:32, Carlos O'Donell wrote:
> On 6/19/20 9:43 AM, Adhemerval Zanella wrote:
>> The symbol was deprecated by strsignal and its usage imposes issues
>> such as copy relocations.
>>
>> Its internal name is changed to __sys_siglist and __sys_sigabbrev to
>> avoid static linking usage.  The compat code is also refactored, since
>> both Linux and Hurd usage the same strategy: export the same array with
>> different object sizes.
>>
>> The libSegfault change avoids calling strsignal on the SIGFAULT signal
>> handler (the current usage is already sketchy, adding a call that
>> potentially issue locale internal function is even sketchier).
>>
>> Checked on x86_64-linux-gnu and i686-linux-gnu. I also run a check-abi
>> on all affected platforms.
> 
> OK for master.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
>> ---

>>
>> diff --git a/NEWS b/NEWS
>> index a660fc59a8..0f5fa0f3b1 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -51,6 +51,12 @@ Deprecated and removed features, and other changes affecting compatibility:
>>  * ldconfig now defaults to the new format for ld.so.cache. glibc has
>>    already supported this format for almost 20 years.
>>  
>> +* The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
>> +  are no longer available to newly linked binaries, and their declarations
>> +  have been removed from <string.h>.  They are exported solely as
>> +  compatibility symbols to support old binaries.  All programs should use
>> +  strsignal instead.
> 
> OK. Thanks for the NEWS entry.
> 
> Could you please update:
> https://sourceware.org/glibc/wiki/Release/2.32#Packaging_Changes
> to indicate this change might affect downstream distros and cause FTBS
> which will need fixing by rewriting to use strsignal()? A code example in
> the wiki might help downstream fix things up.

Done, I plan to extend the entry with an example of using the new safe
interface once I reach the patch in my rebase.