public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/4] Sync getcwd with gnulib
Date: Wed, 26 Aug 2020 15:39:37 -0700	[thread overview]
Message-ID: <61651bc1-1228-3dd8-be82-83d0407984e8@cs.ucla.edu> (raw)
In-Reply-To: <20200826210246.2830973-1-adhemerval.zanella@linaro.org>

Thanks for looking into this. To help move this along from the Gnulib point of 
view, I merged the Gnulib-relevant parts of those proposed glibc patches into 
Gnulib, here:

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=615b43e1f914687b6ccd40c79a05626098a361d7

but this Gnulib patch has the following further changes to get this to work, and 
these further changes should be in the glibc version too:

>    - It does not include pathmax.h header (glibc does not provide it).

That #include can be moved into a previous "#if !_LIBC" section.

> +# define __getcwd rpl_getcwd

This should define __getcwd_generic, not __getcwd, since the function name changed.



Also, here are some minor refactorings to the resulting getcwd-generic.c that 
would improve readability. If you add these I plan to merge them into Gnulib too.

* Prefer "#if _LIBC" to "#if !_LIBC", interchanging 'then' and 'else' parts.

* Put those !_LIBC #defines in alphabetic order.

  parent reply	other threads:[~2020-08-26 22:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 21:02 Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 2/4] linux: Remove __ASSUME_ATFCTS Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 3/4] Use LFS readdir in generic POSIX getcwd [BZ# 22899] Adhemerval Zanella
2020-08-27  9:58   ` Florian Weimer
2020-08-26 21:02 ` [PATCH 4/4] io: Reorganize the getcwd implementation Adhemerval Zanella
2020-08-26 22:39   ` Paul Eggert
2020-08-27 12:35   ` Adhemerval Zanella
2020-08-27 13:21     ` Florian Weimer
2020-08-27 13:40       ` Adhemerval Zanella
2020-08-27 17:29     ` Adhemerval Zanella
2020-08-27 19:20   ` [PATCH v2] " Adhemerval Zanella
2020-08-27 23:44     ` Paul Eggert
2020-08-31 18:27       ` Adhemerval Zanella
2020-08-26 22:39 ` Paul Eggert [this message]
2020-08-27 11:07   ` [PATCH 1/4] Sync getcwd with gnulib Adhemerval Zanella
2020-08-27  8:14 ` Florian Weimer
2020-08-27 10:53   ` Adhemerval Zanella
2020-08-27 10:58     ` Florian Weimer
2020-08-27 11:06       ` Adhemerval Zanella
2020-08-27 11:10         ` Florian Weimer
2020-08-27 11:33           ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61651bc1-1228-3dd8-be82-83d0407984e8@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).