From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 46D90385B526 for ; Thu, 9 Feb 2023 19:43:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46D90385B526 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32e.google.com with SMTP id j6-20020a9d7686000000b0068d4ba9d141so885202otl.6 for ; Thu, 09 Feb 2023 11:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=c/CWZEqA6reAvXSqnkJtN4QkJoZ5IoDpw2fq+UW4NXo=; b=mJjyCy3I99hm6xr19kI0T9yAafB06HuLFaBJYofnG3D0hGZbs5BhBnZlrGUtnjPgwn qRMnqheGzWX2hycamfzcUY8/OGmXMuUMBQlNQBlEkiv7YCkS8H88HRA0csVisYKRiU+7 DMMBoHgIjw3y0jr+VGLxqqgMpanBxMP8EtCowocVf9ZNAHvC9UMIFUjYmLiLi1qE0RwN Oe8t7IEFNrHgWvWIeBcayqcOQFQTZpuiCSeDZSgdb99lNOMew67lQfBOHxof7zp+pSnt NoLvE2M3+KgktSljFHaiJ7fMvt5A9CMtN/q7IoKjnUB7wVaOfkbp3d8X1wyLQ7mH7U7p ZWIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c/CWZEqA6reAvXSqnkJtN4QkJoZ5IoDpw2fq+UW4NXo=; b=VhFD1lGu9WjR+FVXIe+kd2AmHbTNexV53LzDN1oNW8cz5GYFuS31QnI3k5zVgPY+m3 RIk4M1HUPtfrEveX8PGMibsHvZeCge12yLJXbk8F19N7lxki+RBL3qrkrfGitWRJ2tVH p9t1vCNWBj9eOQT1vzRQZ4UPAGwBsXQwaoGq5NBpXc/s3OEaD/APFJAu7x9xoAAX3Wcr uXQHXUjxyXhbvomyNIpy1E3tiMM3VxEtXinKLOcy8RnyKduiRHxgqvtKViiAPipVB46y DoGOi5/ptDVlvxo/8GQaQwVU74YPXvzOKppLv5Hs+sl2Y8/pTAb3TCMrHYJ5sHujEO+O S5Hw== X-Gm-Message-State: AO0yUKWcCmE8GAFdRbBd+F3b8JtX7RpEUX86X7m5NKFge5ohOdGGen+j hBLDabrrzTPLQzFuzueM7N2AKzfdbDryUk01urU= X-Google-Smtp-Source: AK7set+vrL4zlcfs7GUixlWQfUJ3KOkkEErlbMxGKL+R0YQWeYgVB79Da2jhVBM9QOcVB0OI/C7jRA== X-Received: by 2002:a9d:3e3:0:b0:68b:cabd:a8d with SMTP id f90-20020a9d03e3000000b0068bcabd0a8dmr7474822otf.24.1675971814064; Thu, 09 Feb 2023 11:43:34 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:8ced:4490:9a44:1abc:1757? ([2804:1b3:a7c2:8ced:4490:9a44:1abc:1757]) by smtp.gmail.com with ESMTPSA id v23-20020a9d5a17000000b0068bc8968753sm1102981oth.17.2023.02.09.11.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 11:43:32 -0800 (PST) Message-ID: <61890062-04b1-d709-abf3-ede0ba32bd0e@linaro.org> Date: Thu, 9 Feb 2023 16:43:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] wchar: Define va_list for POSIX (BZ #30035) Content-Language: en-US From: Adhemerval Zanella Netto To: libc-alpha@sourceware.org, Andreas Schwab References: <20230124174959.1718640-1-adhemerval.zanella@linaro.org> Organization: Linaro In-Reply-To: <20230124174959.1718640-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. On 24/01/23 14:49, Adhemerval Zanella wrote: > This was uncovered by a recent clang change [1]. Different than ISO C, > POSIX states that va_list should be exported by wchar.h [2]. > > Checked on x86_64-linux-gnu and aarch64-linux-gnu. > > [1] https://reviews.llvm.org/D137268 > [2] https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/basedefs/wchar.h.html > --- > conform/data/wchar.h-data | 3 +++ > wcsmbs/wchar.h | 11 +++++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/conform/data/wchar.h-data b/conform/data/wchar.h-data > index e414651a33..0af74e14bc 100644 > --- a/conform/data/wchar.h-data > +++ b/conform/data/wchar.h-data > @@ -15,6 +15,9 @@ type size_t > type locale_t > # endif > tag {struct tm} > +# if !defined ISO99 && !defined ISO11 && !defined UNIX98 > +type va_list > +# endif > > function wint_t btowc (int) > function int fwprintf (FILE*, const wchar_t*, ...) > diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h > index 69e920b8c2..ca145bb8d2 100644 > --- a/wcsmbs/wchar.h > +++ b/wcsmbs/wchar.h > @@ -37,6 +37,17 @@ > #define __need___va_list > #include > > +#if defined __USE_XOPEN2K || defined __USE_XOPEN2K8 > +# ifdef __GNUC__ > +# ifndef _VA_LIST_DEFINED > +typedef __gnuc_va_list va_list; > +# define _VA_LIST_DEFINED > +# endif > +# else > +# include > +# endif > +#endif > + > #include > #include > #include