[PATCH] RISC-V: Use builtin for copysign and copysignf

[PATCH] RISC-V: Use builtin for copysign and copysignf

[Julian Zhu]

The built-in functions `builtin_{copysign, copysignf}` are sufficient to generate correct `fsgnj.d/fsgnj.s` instructions on RISC-V.

Signed-off-by: Julian Zhu <jz531210@gmail.com>
---
 sysdeps/riscv/rvd/s_copysign.c  | 29 -----------------------------
 sysdeps/riscv/rvf/s_copysignf.c | 29 -----------------------------
 2 files changed, 58 deletions(-)
 delete mode 100644 sysdeps/riscv/rvd/s_copysign.c
 delete mode 100644 sysdeps/riscv/rvf/s_copysignf.c

diff --git a/sysdeps/riscv/rvd/s_copysign.c b/sysdeps/riscv/rvd/s_copysign.c
deleted file mode 100644
index 6c0c9461ba..0000000000
--- a/sysdeps/riscv/rvd/s_copysign.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/* Copy sign bit between floating-point values.  RISC-V version.
-   Copyright (C) 2017-2024 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#define NO_MATH_REDIRECT
-#include <math.h>
-#include <libm-alias-double.h>
-
-double
-__copysign (double x, double y)
-{
-  asm ("fsgnj.d %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
-  return x;
-}
-libm_alias_double (__copysign, copysign)
diff --git a/sysdeps/riscv/rvf/s_copysignf.c b/sysdeps/riscv/rvf/s_copysignf.c
deleted file mode 100644
index f34d37b977..0000000000
--- a/sysdeps/riscv/rvf/s_copysignf.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/* copysignf().  RISC-V version.
-   Copyright (C) 2017-2024 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#define NO_MATH_REDIRECT
-#include <math.h>
-#include <libm-alias-float.h>
-
-float
-__copysignf (float x, float y)
-{
-  asm ("fsgnj.s %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
-  return x;
-}
-libm_alias_float (__copysign, copysign)
-- 
2.46.0

Re: [PATCH] RISC-V: Use builtin for copysign and copysignf

[Julian Zhu]

Ping.


在 2024/9/11 16:05, Julian Zhu 写道:
> The built-in functions `builtin_{copysign, copysignf}` are sufficient to generate correct `fsgnj.d/fsgnj.s` instructions on RISC-V.
>
> Signed-off-by: Julian Zhu <jz531210@gmail.com>
> ---
>   sysdeps/riscv/rvd/s_copysign.c  | 29 -----------------------------
>   sysdeps/riscv/rvf/s_copysignf.c | 29 -----------------------------
>   2 files changed, 58 deletions(-)
>   delete mode 100644 sysdeps/riscv/rvd/s_copysign.c
>   delete mode 100644 sysdeps/riscv/rvf/s_copysignf.c
>
> diff --git a/sysdeps/riscv/rvd/s_copysign.c b/sysdeps/riscv/rvd/s_copysign.c
> deleted file mode 100644
> index 6c0c9461ba..0000000000
> --- a/sysdeps/riscv/rvd/s_copysign.c
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/* Copy sign bit between floating-point values.  RISC-V version.
> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library.  If not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#define NO_MATH_REDIRECT
> -#include <math.h>
> -#include <libm-alias-double.h>
> -
> -double
> -__copysign (double x, double y)
> -{
> -  asm ("fsgnj.d %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
> -  return x;
> -}
> -libm_alias_double (__copysign, copysign)
> diff --git a/sysdeps/riscv/rvf/s_copysignf.c b/sysdeps/riscv/rvf/s_copysignf.c
> deleted file mode 100644
> index f34d37b977..0000000000
> --- a/sysdeps/riscv/rvf/s_copysignf.c
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/* copysignf().  RISC-V version.
> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library.  If not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#define NO_MATH_REDIRECT
> -#include <math.h>
> -#include <libm-alias-float.h>
> -
> -float
> -__copysignf (float x, float y)
> -{
> -  asm ("fsgnj.s %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
> -  return x;
> -}
> -libm_alias_float (__copysign, copysign)

Re: [PATCH] RISC-V: Use builtin for copysign and copysignf

[Adhemerval Zanella Netto]

On 11/09/24 05:05, Julian Zhu wrote:
> The built-in functions `builtin_{copysign, copysignf}` are sufficient to generate correct `fsgnj.d/fsgnj.s` instructions on RISC-V.
> 
> Signed-off-by: Julian Zhu <jz531210@gmail.com>

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/riscv/rvd/s_copysign.c  | 29 -----------------------------
>  sysdeps/riscv/rvf/s_copysignf.c | 29 -----------------------------
>  2 files changed, 58 deletions(-)
>  delete mode 100644 sysdeps/riscv/rvd/s_copysign.c
>  delete mode 100644 sysdeps/riscv/rvf/s_copysignf.c
> 
> diff --git a/sysdeps/riscv/rvd/s_copysign.c b/sysdeps/riscv/rvd/s_copysign.c
> deleted file mode 100644
> index 6c0c9461ba..0000000000
> --- a/sysdeps/riscv/rvd/s_copysign.c
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/* Copy sign bit between floating-point values.  RISC-V version.
> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library.  If not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#define NO_MATH_REDIRECT
> -#include <math.h>
> -#include <libm-alias-double.h>
> -
> -double
> -__copysign (double x, double y)
> -{
> -  asm ("fsgnj.d %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
> -  return x;
> -}
> -libm_alias_double (__copysign, copysign)
> diff --git a/sysdeps/riscv/rvf/s_copysignf.c b/sysdeps/riscv/rvf/s_copysignf.c
> deleted file mode 100644
> index f34d37b977..0000000000
> --- a/sysdeps/riscv/rvf/s_copysignf.c
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/* copysignf().  RISC-V version.
> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library.  If not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#define NO_MATH_REDIRECT
> -#include <math.h>
> -#include <libm-alias-float.h>
> -
> -float
> -__copysignf (float x, float y)
> -{
> -  asm ("fsgnj.s %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
> -  return x;
> -}
> -libm_alias_float (__copysign, copysign)

Re: [PING] [PATCH] RISC-V: Use builtin for copysign and copysignf

[Julian Zhu]

Ping, Thanks.

在 2024/10/29 3:35, Adhemerval Zanella Netto 写道:
>
> On 11/09/24 05:05, Julian Zhu wrote:
>> The built-in functions `builtin_{copysign, copysignf}` are sufficient to generate correct `fsgnj.d/fsgnj.s` instructions on RISC-V.
>>
>> Signed-off-by: Julian Zhu <jz531210@gmail.com>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>
>> ---
>>   sysdeps/riscv/rvd/s_copysign.c  | 29 -----------------------------
>>   sysdeps/riscv/rvf/s_copysignf.c | 29 -----------------------------
>>   2 files changed, 58 deletions(-)
>>   delete mode 100644 sysdeps/riscv/rvd/s_copysign.c
>>   delete mode 100644 sysdeps/riscv/rvf/s_copysignf.c
>>
>> diff --git a/sysdeps/riscv/rvd/s_copysign.c b/sysdeps/riscv/rvd/s_copysign.c
>> deleted file mode 100644
>> index 6c0c9461ba..0000000000
>> --- a/sysdeps/riscv/rvd/s_copysign.c
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -/* Copy sign bit between floating-point values.  RISC-V version.
>> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
>> -   This file is part of the GNU C Library.
>> -
>> -   The GNU C Library is free software; you can redistribute it and/or
>> -   modify it under the terms of the GNU Lesser General Public
>> -   License as published by the Free Software Foundation; either
>> -   version 2.1 of the License, or (at your option) any later version.
>> -
>> -   The GNU C Library is distributed in the hope that it will be useful,
>> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> -   Lesser General Public License for more details.
>> -
>> -   You should have received a copy of the GNU Lesser General Public
>> -   License along with the GNU C Library.  If not, see
>> -   <https://www.gnu.org/licenses/>.  */
>> -
>> -#define NO_MATH_REDIRECT
>> -#include <math.h>
>> -#include <libm-alias-double.h>
>> -
>> -double
>> -__copysign (double x, double y)
>> -{
>> -  asm ("fsgnj.d %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
>> -  return x;
>> -}
>> -libm_alias_double (__copysign, copysign)
>> diff --git a/sysdeps/riscv/rvf/s_copysignf.c b/sysdeps/riscv/rvf/s_copysignf.c
>> deleted file mode 100644
>> index f34d37b977..0000000000
>> --- a/sysdeps/riscv/rvf/s_copysignf.c
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -/* copysignf().  RISC-V version.
>> -   Copyright (C) 2017-2024 Free Software Foundation, Inc.
>> -   This file is part of the GNU C Library.
>> -
>> -   The GNU C Library is free software; you can redistribute it and/or
>> -   modify it under the terms of the GNU Lesser General Public
>> -   License as published by the Free Software Foundation; either
>> -   version 2.1 of the License, or (at your option) any later version.
>> -
>> -   The GNU C Library is distributed in the hope that it will be useful,
>> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> -   Lesser General Public License for more details.
>> -
>> -   You should have received a copy of the GNU Lesser General Public
>> -   License along with the GNU C Library.  If not, see
>> -   <https://www.gnu.org/licenses/>.  */
>> -
>> -#define NO_MATH_REDIRECT
>> -#include <math.h>
>> -#include <libm-alias-float.h>
>> -
>> -float
>> -__copysignf (float x, float y)
>> -{
>> -  asm ("fsgnj.s %0, %1, %2" : "=f" (x) : "f" (x), "f" (y));
>> -  return x;
>> -}
>> -libm_alias_float (__copysign, copysign)