From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 1D5273858C2B for ; Mon, 23 Oct 2023 14:08:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D5273858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D5273858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698070107; cv=none; b=knKXxU/wFNMlwliEmP+kyDfFM+XVmv9s3v09nvkZCs7e6auHWMcCk+9t4z2gzlvToSrjjyyS9Kitdz2/xEgyiePf63IpZFlM7mRflittNHzzpyzVd0vl9B/NTVzesZ36jXHDQjc7vQ+U6SijvKx8kiQqkRAGU8jGPDMogoKa/y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698070107; c=relaxed/simple; bh=TE6afJH8KfAO6Otb9nluamOZyQ/TjTlTE3iYYiKAc/I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WgNy5o3+mYJOJzRLCtW0c9zHclTlB9JmDjlSlHUkBtSqgvfBEosQkR1PuMDYOz6SR9S3zynlIyUp8OVAlNgPYQshnhKC3tBJcoL2roO8T0390dtTq90a/8TO49CMLT3OPvZ9Fpbh2/algoo2BVlvATZUXlsveg89+Prg9sDDrc4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6b77ab73c6fso2376415b3a.1 for ; Mon, 23 Oct 2023 07:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698070105; x=1698674905; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6DzznaqqJ3a1wu4vd/u4JUWBExSAdctM5dbT2E5AQhQ=; b=vyu/DKJ/W30fmJP9i1XM+z96aAx2DPS3xSozpMeVmAcX18bj+R3oYa/L6eiUTEEze2 m131NgjLaH1UvB0pPbbRGHn4M0kz/hUuJ3D9CauzhRbgBMApfVoWbtFVtXyR0gC0oHAS AteQrWVihPBPFbTirAAZ62RKaFYTguWlpcAYhmYkYjFy3Ue68dGUbgC/d6TK00BivEAo 3wX35uZ3R7l8aLhSC461ga6g2AzCwZPlNG+u692Vw6zR43HFy4ehZELbi6kUcyVsnOo2 5X7cJP7rUqonpUfsrTqLsMhA/GgE/O2+TJnd0AoH1eDHNXqecQ2Fl9VWgXto4gOM5Y5K l5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698070105; x=1698674905; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6DzznaqqJ3a1wu4vd/u4JUWBExSAdctM5dbT2E5AQhQ=; b=DqKV5UcJxZm+k+O5uWW+lHgv28gQsE3lbAVb9LP4kQfHAHn2oIkcHnO4rp7jsCEA69 F3mxlU1z2MwD0VWHlTsTnDS6Xdt2rYzLJDkpdS7HWEFPmzoaMgXphSt6EH/Wn/G9h0zp 9w8+rms3Nwk0Kwoih1u1Ubso78tQn2cRFPULpPyPb7y2fW/4Qt3/qG7EWC+L4/8AmGUg HGJiC9MnI7HXgcol2ZJdtrx8CTYQj7ufqBm4RC1qPGhrfBtPgsBQ35rl7Z0nLPW9Fisc /NdlIATWDDQFDhg1rhaW8PlRNl1MvvdFAQLkpPDyyALxc5dZbfW8oT0t1RpOl/roS/6k 6HYw== X-Gm-Message-State: AOJu0YxDYpVTkZOZc/s7hD69wba2BUmcyvJH8bC+GFtzxleNToMSNeu9 w5mIR4FZaMoZXY6pgSNqrBzKw6+fnEDzta8mxzghAw== X-Google-Smtp-Source: AGHT+IFY4e0pixtfP4TRaZ6ge0nBfH/i0EDa1aXeqNdSooJj29FS093/1F4HdYLGAcUr/wswS3fhYg== X-Received: by 2002:a05:6a20:3ca3:b0:151:35ad:f331 with SMTP id b35-20020a056a203ca300b0015135adf331mr12330317pzj.14.1698070104867; Mon, 23 Oct 2023 07:08:24 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:a647:f05a:5f8b:2693:4fff? ([2804:1b3:a7c3:a647:f05a:5f8b:2693:4fff]) by smtp.gmail.com with ESMTPSA id z19-20020a63e113000000b00577d53c50f7sm5862399pgh.75.2023.10.23.07.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 07:08:24 -0700 (PDT) Message-ID: <61a5a5b7-9b75-4892-9cf5-6c0bb999ae85@linaro.org> Date: Mon, 23 Oct 2023 11:08:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] test-container: disable ld.so system cache on DSO detection Content-Language: en-US To: Simon Chopin , libc-alpha@sourceware.org References: <20231005125431.3958485-1-simon.chopin@canonical.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/10/23 07:11, Simon Chopin wrote: > Hi! > > Quoting Adhemerval Zanella Netto (2023-10-17 16:48:55) >> >> >> On 05/10/23 09:54, Simon Chopin wrote: >>> When building the testroot, the script runs the newly built ld.so on a >>> couple of binaries in order to copy over any additional libararies >> >> s/libararies/libraries >> >>> needed. However, if the dependencies are found in the system cache, it >>> will be copied over using that path. >>> >>> This is problematic if the system ld.so and the one built don't have the >>> exact same search configuration. We encountered this in Ubuntu, where we >>> build a variant of libc with -fno-omit-frame-pointer for accurate >>> performance profiling. >>> >>> This variant is built using a non-standard slibdir to be able to be >>> co-installed with the default library (e.g. slibdir = /lib/libc6-prof). >>> Since we have /lib pointing to /usr/lib, any additional dependency >>> should still be reachable via /usr. However, resolving via the cache >>> might result in the additional DSOs being copied into $testroot/lib, out >>> of the search path in the container. >>> >>> The problem has been triggered by 1d5024f4f052c12e404d42d3b5bfe9c3e9fd27c4 >>> ("support: Build with exceptions and asynchronous unwind tables [BZ #30587]") >>> which introduced a dependency on libgcc_s.so.1 under some circumstances. >>> >>> Downstream bug: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/2031495 >> >> It makes sense to inhibit cache on testroot creation, although default >> system dirs will always be used. >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella > > Sorry, my experience of ML-based contributions is pretty limited. Am I > expected to send a V2 to fix the typo in the commit log? > > If I need to send a V2, should it include the Reviewed-by tag? No need, I will commit in your behalf with the commit message fixed.