From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-98294-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 39176 invoked by alias); 13 Dec 2018 03:29:00 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 39141 invoked by uid 89); 13 Dec 2018 03:28:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*cn, H*r:0800
X-HELO: spam2.hygon.cn
From: Jinke Fan <fanjinke@hygon.cn>
Subject: Re: [PATCH] x86: Add Hygon Dhyana support.
To: "Carlos O'Donell" <carlos@redhat.com>,
        "libc-alpha@sourceware.org"
	<libc-alpha@sourceware.org>,
        "Pawar, Amit" <Amit.Pawar@amd.com>
CC: "H.J. Lu" <hjl.tools@gmail.com>
References: <20181210102609.28819-1-fanjinke@hygon.cn>
 <7cca34e9-2ef9-50f8-173b-63f47313435a@redhat.com>
 <de22d971-14f1-db0e-6245-6cd1018c04f3@hygon.cn>
 <f8d3865c-7b8c-d650-da55-0b5c91e34bfc@redhat.com>
Message-ID: <61aca0b4-6c1a-a47b-a4c6-d42442332cc1@hygon.cn>
Date: Thu, 13 Dec 2018 07:44:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <f8d3865c-7b8c-d650-da55-0b5c91e34bfc@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MAIL:spam2.hygon.cn wBD3Samp046758
X-DNSRBL: 
X-SW-Source: 2018-12/txt/msg00459.txt.bz2

On 12/12/2018 10:32 PM, Carlos O'Donell wrote:
> On 12/12/18 2:21 AM, Jinke Fan wrote:
>> Thank you for your reply and reminder.
>>
>> The copyright issue is already under processing.
>   
> Jinke,
> 
> Please review the attached patch. It is what I plan to commit for you.
> 
> I notice you use 'fanjinke' as your ChangeLog name, is that correct?
> 
> I added a 'Signed-off-by' for you in the commit message, is that OK?
> 
> The only changes I made to your patch:
> 
> * Finished the ChangeLog entry which was missing text after the
>    identified function change.
> 
> * Added space after '.' in comment in cpu-features.c (two spaces after
>    period is GNU coding convention).
> 
> If everything looks OK to you I will commit this for you.
> 
Carlos,

Yes, everything looks OK to me.

Thank you very much!