From: Florian Weimer <fweimer@redhat.com>
To: Zack Weinberg <zackw@panix.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>, Rical Jasan <rj@2c3t.io>,
Thorsten Kukuk <kukuk@suse.de>
Subject: Re: [PATCH 4/4] New configure option --disable-crypt.
Date: Thu, 21 Jun 2018 09:31:00 -0000 [thread overview]
Message-ID: <622c0da0-630b-d81d-4c56-506fcc2493ef@redhat.com> (raw)
In-Reply-To: <CAKCAbMgXmyZYpNXLoJHs1aJTT+E7OFakLC6PQGjsGh9Z5BcMwQ@mail.gmail.com>
On 06/21/2018 12:47 AM, Zack Weinberg wrote:
> On Wed, Jun 20, 2018 at 4:40 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 05/22/2018 12:34 AM, Joseph Myers wrote:
>>> On Mon, 21 May 2018, Zack Weinberg wrote:
>>>> No, this is an intentional deviation from the present state of POSIX,
>>>> anticipating the removal of those functions from the standard.
>>>
>>> That would only seem relevant to the _XOPEN_CRYPT value in future POSIX
>>> modes, not current ones.
>>
>> So we should stop defining _XOPEN_CRYPT, but continue to declare crypt in
>> <unistd.h> for __USE_MISC || __USE_XOPEN? That would work for me.
>
> Again, I think that it is inappropriate to stop defining _XOPEN_CRYPT
> in any mode. Yes, this is an intentional deviation from POSIX, but I
> think it is far less likely to break existing programs than the
> alternative.
How can we resolve this conflict?
We have mostly cleaned up Fedora 28 to build with !_XOPEN_CRYPT already.
There weren't many changes AFAICS, and they fall broadly into two
categories:
(1) Not including <crypt.h> for the crypt function, only <unistd.h>.
(2) Using DES functions.
(1) was far more common than (2).
We'll keep the declaration of crypt in <unistd.h> for _DEFAULT_SOURCE,
so (1) will not be a problem. (2) will not be addressed independently
of the definition of _XOPEN_CRYPT.
This is why I'm fine with Joseph's approach. It may even make it
marginally easier to check whether you need your own DES implementation.
I would like to see a decision soon because I'm wondering if I have to
back out the libxcrypt switch.
Thanks,
Florian
next prev parent reply other threads:[~2018-06-21 9:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 17:39 [PATCH 0/4 v3] libcrypt phaseout Zack Weinberg
2018-05-21 17:39 ` [PATCH 4/4] New configure option --disable-crypt Zack Weinberg
2018-05-21 19:52 ` Joseph Myers
2018-05-21 22:07 ` Zack Weinberg
2018-05-21 22:34 ` Joseph Myers
2018-05-22 1:08 ` Zack Weinberg
2018-06-20 20:40 ` Florian Weimer
2018-06-20 22:48 ` Zack Weinberg
2018-06-21 9:31 ` Florian Weimer [this message]
2018-06-21 9:32 ` Florian Weimer
2018-06-28 18:52 ` Zack Weinberg
2018-05-21 17:39 ` [PATCH 2/4] Reorganize crypt.texi Zack Weinberg
2018-05-23 5:23 ` Rical Jasan
2018-05-21 17:39 ` [PATCH 1/4] Disallow use of DES encryption functions in new programs Zack Weinberg
2018-05-22 6:58 ` Florian Weimer
2018-05-23 3:37 ` Rical Jasan
2018-05-23 16:50 ` Joseph Myers
2018-05-21 17:39 ` [PATCH 3/4] Revise crypt.texi Zack Weinberg
2018-05-25 2:52 ` Rical Jasan
2018-06-25 12:21 ` Florian Weimer
2018-06-25 12:26 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2018-05-06 17:52 [PATCH 0/4 v3] Revise crypto documentation, deprecate DES, add --disable-crypt Zack Weinberg
2018-05-06 17:52 ` [PATCH 4/4] New configure option --disable-crypt Zack Weinberg
2018-05-08 15:00 ` Florian Weimer
2018-05-08 15:22 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622c0da0-630b-d81d-4c56-506fcc2493ef@redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=kukuk@suse.de \
--cc=libc-alpha@sourceware.org \
--cc=rj@2c3t.io \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).