From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bisque.elm.relay.mailchannels.net (bisque.elm.relay.mailchannels.net [23.83.212.18]) by sourceware.org (Postfix) with ESMTPS id 24C333857C4F for ; Tue, 10 Jan 2023 13:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24C333857C4F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4BEBB20172B; Tue, 10 Jan 2023 13:03:19 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B714D2008AF; Tue, 10 Jan 2023 13:03:18 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1673355798; a=rsa-sha256; cv=none; b=CQ+qu7v69vIZyO3AFV85Ibje/AYyCVj/61vLRzBAbGcRBwRiGPPhuQy4SIpOeGeDqqUF9b dbkjr3UWAAPKYpt2S+IqKXlgb4qd4wZizTPChn5ZN2+2F6ynRUWsCTS2+I903SWkm89Lbh ErANg8vn0g68bDJtVrnEOEc1pb3qHiVK7NH+CzhCVJzD2FS87eEkLe3VPlp7WZS1FeF+4O 6KQ3RkW2D59Hz3gd3OD1gkvJwuzXXC56wvpbsGWRQbJ1ip8VcvXl0Rb7QpHiC8MzyUZ19P kTF8aewZ6jiQVXqHQ8XS1rIWlstZCYzgj34E4gTgcjaiGHPKhDx+b/aYRlraNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1673355798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=orIYoM9fgPCcyXFkJ8UFdvMA7aSVX5ZYSD+pSgYIC94=; b=k74SwNzSvZ67z3QRifxcRfGwJOPgcyhrRlI3amXJWosFYofuzOrYF5dLChUas9Xp83Xt2T 9vQ3vYKEj0YZpnhMaWQ6L5bGigmaG4na6b28Cnze9R6tnEoUHAOSxF4QXRGkR22j21qDVs HAZweNqEmBYYcAi6MfTTd5fSad5Mxojs4LAERQ7FwqHKBXqIVkYfMTooIP7bgfSWT7cmnN +2uj8Yx8Fd8ZjSIJqzD7qDS1icKPnf+2CxqEgFwoKEuECp25DV3GHTJeNRk0wPqV6gZTM5 HihlyMcDfKWwHdl1u60LH/eM+jjF8MczNyepCzWCiN8LfkyPwOEFnoDMmQn42Q== ARC-Authentication-Results: i=1; rspamd-6f569fcb69-xrxdf; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Whimsical-Macabre: 1ad28b2e1753b62b_1673355799051_743205548 X-MC-Loop-Signature: 1673355799051:1353613502 X-MC-Ingress-Time: 1673355799051 Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.74.30 (trex/6.7.1); Tue, 10 Jan 2023 13:03:19 +0000 Received: from [192.168.0.182] (bras-base-toroon4834w-grc-23-76-68-24-147.dsl.bell.ca [76.68.24.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4Nrrb96SL6zB8; Tue, 10 Jan 2023 05:03:17 -0800 (PST) Message-ID: <6258df48-5185-2d5d-103d-fd64873d45aa@sourceware.org> Date: Tue, 10 Jan 2023 08:03:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] Add _FORTIFY_SOURCE implementation documentation [BZ #28998] Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20221215162506.1802077-1-siddhesh@sourceware.org> <20221222160403.4151387-1-siddhesh@sourceware.org> <87eds3k9kk.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <87eds3k9kk.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1165.7 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-09 10:32, Florian Weimer wrote: > * Siddhesh Poyarekar: > >> +The following functions are fortified in @theglibc{}: >> + >> +@itemize @bullet >> +@item @code{asprintf}: Replaced with @code{__asprintf_chk}. >> + >> +@item @code{confstr}: Replaced with @code{__confstr_chk}. >> + >> +@item @code{dprintf}: Replaced with @code{__dprintf_chk}. > > For the *printf* functions, the replacement depends on the architecture > and compilation mode (the concrete type of long double). Oh yeah, I had missed the __nldbl_* ones and, TIL about the ieee128 ones. And guess what, I tried another way to look up this list (through Versions files) and found that mq_open is also fortified! >> +@item @code{explicit_bzero}: Replaced with @code{__explicit_bzero_chk}. >> + >> +@item @code{FD_SET}: Replaced with @code{__fdelt_chk}. >> + >> +@item @code{FD_CLR}: Replaced with @code{__fdelt_chk}. >> + >> +@item @code{FD_ISSET}: Replaced with @code{__fdelt_chk}. > > These three macros (not functions) aren't replaced, but enhanced. > > Maybe just mentioned the list of functions/macros, and point towards the > general pattern, but also note the presence of exceptions? Ack, v4 coming up. Thanks, Sid