From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 4E06A385841D for ; Thu, 25 Aug 2022 15:28:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E06A385841D Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1661441292; bh=aQg/5VfHTO/SJcukqgnYvEJmhZJ7mo9D+MDlkg+I84U=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=e17+sfAx/2AzuSmqbTkGmLSYp3b0AgBOh7i6FmnYSLNikbC4lYZ/cvrY1gSRU6RPD E6uhjuxPgmCB5UtnrcJUTCS5kHOFFTBeCsX8fHLWQ7yA5KMNL4m78I2MiSrJIeZUeF vGo/5MZZ7n0sb8nOq1d5Hyk3aMGq+J5mvsgywCFw= Received: from [IPv6:240e:358:1158:500:dc73:854d:832e:3] (unknown [IPv6:240e:358:1158:500:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id D2E49669A1; Thu, 25 Aug 2022 11:28:07 -0400 (EDT) Message-ID: <627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site> Subject: Re: [PATCH 1/2] LoongArch: Fix ptr mangling/demangling features. From: Xi Ruoyao To: Adhemerval Zanella Netto , caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name Cc: xuchenghua@loongson.cn Date: Thu, 25 Aug 2022 23:27:55 +0800 In-Reply-To: <8562da19-d9d3-a4f3-2aae-2a4489af6806@linaro.org> References: <20220823122833.1561228-1-caiyinyu@loongson.cn> <20220823122833.1561228-2-caiyinyu@loongson.cn> <8562da19-d9d3-a4f3-2aae-2a4489af6806@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,LIKELY_SPAM_FROM,PDS_OTHER_BAD_TLD,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote: > Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELO= CS? The > PTR_MANGLE is used some specific cases and hardly a hotstop. LDST_PCREL added as a macro in sysdep.h, so further assembly implementations might reuse it then it may appear in some hot spot. If we quote "optimization too early is the ultimate evil", we can drop it for now and review once we use LDST_PCREL somewhere else. But to me this is rather a simple autoconf check and I can't figure out a situation where it's evil... --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University