From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 6A5F93857C79 for ; Mon, 25 Jul 2022 08:22:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A5F93857C79 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxz9OnUt5iLT02AA--.54168S3; Mon, 25 Jul 2022 16:22:00 +0800 (CST) Subject: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES To: WANG Xuerui , Xi Ruoyao , adhemerval.zanella@linaro.org, libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com Cc: liuzhensong@loongson.cn References: <20220719012056.1461897-1-caiyinyu@loongson.cn> <71ad82b8b669d4233b7fd4741add7b58bd7ac20e.camel@xry111.site> <2ff6d3b4-36d2-c7cc-e1b1-119a93ec5423@xen0n.name> From: caiyinyu Message-ID: <6339e6bd-94a2-4d4a-069a-c332a48bd241@loongson.cn> Date: Mon, 25 Jul 2022 16:21:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2ff6d3b4-36d2-c7cc-e1b1-119a93ec5423@xen0n.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9Dxz9OnUt5iLT02AA--.54168S3 X-Coremail-Antispam: 1UD129KBjvJXoW3WFWUJFWkKw17ZFWUGFW5GFg_yoW7GF45pa saqFn5JrWUCFZ5Ary2k3Wjqa40yFn3t3Z8GryDWFy8u34kZr9FqrWSqr1Y9FnrGr4vkF4Y vry8t3W7uFyDZ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvS14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7I2V7IY0VAS07AlzVAY IcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43 ZEXa7VUbXdbUUUUUU== X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 08:22:12 -0000 Summary of test results:        1 FAIL     4576 PASS       22 UNSUPPORTED       12 XFAIL        6 XPASS Overall this is looking good. Thanks for your testing. So, is it necessary to release another version of v8?? 在 2022/7/24 下午8:02, WANG Xuerui 写道: > On 7/24/22 19:51, Xi Ruoyao wrote: >> On Sun, 2022-07-24 at 17:49 +0800, WANG Xuerui wrote: >> >>> Of these, the ifunc failures are "expected" by you, the >>> elf/check-abi-libc diff is trivial (maybe you just didn't rebase as >>> frequently): >>> >>> --- ../sysdeps/unix/sysv/linux/loongarch/lp64/libc.abilist 2022-07-23 >>> 14:45:57.490029442 +0800 >>> +++ /home/xenon/src/glibc/build/libc.symlist    2022-07-24 >>> 13:44:10.416642655 +0800 >>> @@ -496 +496 @@ GLIBC_2.36 _mcount F >>> -GLIBC_2.36 _nl_default_dirname D 0x12 >>> +GLIBC_2.36 _nl_default_dirname D 0x17 >>> @@ -541,0 +542,3 @@ GLIBC_2.36 alphasort64 F >>> +GLIBC_2.36 arc4random F >>> +GLIBC_2.36 arc4random_buf F >>> +GLIBC_2.36 arc4random_uniform F >> arc4random is just merged two days ago. > Yeah; I meant to alert the relevant people (patch author or committer) > to not forget adjusting this. >> >>> The others may need some love. Of course they're possibly because of my >>> particular environment (Gentoo is a little bit different than >>> "ordinary" >>> distros like Debian/Fedora, and I already have to symlink the >>> libgcc_s.so and libstdc++.so to pass the nptl tests at all) >> I can tell tst-nss-files-hosts-long is most likely PR24816.  For the >> others I'm not sure. >> >> By "symlink libgcc_s.so and libstdc++.so" I guess you are running tests >> in a temporary system ("Gentoo stage 1" IIRC).  In LFS we also get some >> additional test failures in the temporary system [1] so it's better to >> rerun the tests in a full system. >> >> (In earlier LFS releases we also needed to symlink libgcc_s.so and >> libstdc++.so for glibc tests, but it's no longer needed now thanks to a >> major refactoring [2].) > > Of course my Gentoo devbox is fully bootstrapped and working :-) > > I'm referring to the Gentoo-specific behavior of slotted gcc > installation, where gcc-provided libraries (including the two > mentioned here) are NOT present in the usual place, but rather in > /usr/lib/gcc/. Additional magic is present for the > "active" gcc to be switchable via the gcc-config tool. Binutils is > similar; there is a binutils-config too. > > But anyway, the nptl tests mostly passed, with the only 2 failures > related to the botched gdb on LoongArch (I compiled from the upstream > HEAD and still it doesn't work). The others are worth looking into too > but don't seem to cause any problem so far. > >> >> [1]: >> https://www.linuxfromscratch.org/lfs/view/systemd/chapter08/glibc.html >> [2]: >> https://lists.linuxfromscratch.org/sympa/arc/lfs-dev/2020-05/msg00000.html >> >> My test result on LFS (fully built) with a patched ld seems clean.  The >> patch is originally published at >> https://sourceware.org/pipermail/binutils/2022-July/121852.html, but >> it's in a large series introducing new relocation types.  I managed to >> rebased and adjusted the patch so it can be applied individually for >> binutils-gdb master branch.  The patch is attached in this mail. >> >> +Zhensong: is there any possibility to merge this patch for binutils >> master and 2.39 release branch (including 2.38 release branch would be >> even better) so at least glibc ifunc tests will be happy? >> >> XPASS: conform/UNIX98/ndbm.h/linknamespace >> XPASS: conform/XOPEN2K/ndbm.h/linknamespace >> XPASS: conform/XOPEN2K8/ndbm.h/linknamespace >> XPASS: conform/XPG42/ndbm.h/linknamespace >> UNSUPPORTED: crypt/cert >> FAIL: elf/check-abi-libc >> UNSUPPORTED: elf/tst-env-setuid >> UNSUPPORTED: elf/tst-env-setuid-tunables >> XPASS: elf/tst-protected1a >> XPASS: elf/tst-protected1b >> UNSUPPORTED: elf/tst-valgrind-smoke >> UNSUPPORTED: misc/tst-adjtimex >> UNSUPPORTED: misc/tst-clock_adjtime >> UNSUPPORTED: misc/tst-ntp_adjtime >> UNSUPPORTED: misc/tst-pkey >> UNSUPPORTED: misc/tst-rseq >> UNSUPPORTED: misc/tst-rseq-disable >> UNSUPPORTED: nptl/test-cond-printers >> UNSUPPORTED: nptl/test-condattr-printers >> UNSUPPORTED: nptl/test-mutex-printers >> UNSUPPORTED: nptl/test-mutexattr-printers >> UNSUPPORTED: nptl/test-rwlock-printers >> UNSUPPORTED: nptl/test-rwlockattr-printers >> UNSUPPORTED: nptl/tst-pthread-gdb-attach >> UNSUPPORTED: nptl/tst-pthread-gdb-attach-static >> UNSUPPORTED: nptl/tst-rseq-nptl >> UNSUPPORTED: stdlib/tst-secure-getenv >> UNSUPPORTED: time/tst-clock_settime >> UNSUPPORTED: time/tst-settimeofday >> Summary of test results: >>        1 FAIL >>     4576 PASS >>       22 UNSUPPORTED >>       12 XFAIL >>        6 XPASS > Overall this is looking good. Thanks for your testing.