From: Sam James <sam@gentoo.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] configure.ac: fix bashisms in configure.ac
Date: Tue, 22 Mar 2022 17:32:43 +0000 [thread overview]
Message-ID: <636FE07B-0CE5-4766-8940-D834504BE212@gentoo.org> (raw)
In-Reply-To: <6a63f6b5-f637-db9a-908c-232c11100a1d@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
> On 22 Mar 2022, at 17:30, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 22/03/2022 14:11, Sam James via Libc-alpha wrote:
>> configure scripts need to be runnable with a POSIX-compliant /bin/sh.
>>
>> On many (but not all!) systems, /bin/sh is provided by Bash, so errors
>> like this aren't spotted. Notably Debian defaults to /bin/sh provided
>> by dash which doesn't tolerate such bashisms as '=='.
>>
>> This retains compatibility with bash.
>>
>> Fixes configure warnings/errors like:
>> ```
>> checking if compiler warns about alias for function with incompatible types... yes
>> /var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: 4209: test: xyes: unexpected operator
>> ```
>>
>> Signed-off-by: Sam James <sam@gentoo.org>
>
> I think you need to regenerate the powerpc64le configure as well.
>
Pff:
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
modified: sysdeps/powerpc/powerpc64/le/configure
modified: sysdeps/powerpc/powerpc64/le/fpu/multiarch/configure
Let's fix that...
Best,
sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
prev parent reply other threads:[~2022-03-22 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 17:11 Sam James
2022-03-22 17:30 ` Adhemerval Zanella
2022-03-22 17:32 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636FE07B-0CE5-4766-8940-D834504BE212@gentoo.org \
--to=sam@gentoo.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).