From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id 3ACD2395C06B for ; Fri, 13 May 2022 13:42:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ACD2395C06B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F3678561F64; Fri, 13 May 2022 13:42:40 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 94A78560F6F; Fri, 13 May 2022 13:42:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1652449360; a=rsa-sha256; cv=none; b=xs62qZKns0ZecnEX31mkTYfwDUHn2/BsJoiv/YhVpOHYwY/KWsLeiawGHYPSpWP4dCRGuM lQPtaF2fSRq1FxEvDzdH1woQVn3f867UOVkIpoDrRU7h1a0G0bueSq40yqH9n1ozfWvDjv uJiP6u4rjRZynrvBb7tFAxf7lBImIUc/6GK5uymJnz/JEj1WtV9X+djipYgAnv0PjWRMJQ c5dmDwnAhJBAUHEv6fK73AEoHGFmFm9rXPbYmHR4OxgA1y3ynfDTPvPVfmOvQuO5KrdX8r yYgnuh5g38ub5Oxofw2kRv/h0L7BmWy2CE/srNUdCiq3bAw1wRRUvBRQt1U/sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1652449360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R077sYmYX+MRHfsf0PG2TlwSErvHwtTBgCzzlMxdtqA=; b=3udW3MI3zmhzND9Dz0e/nqSLWoy7BDMDBwtC1YPLTY5OcpHHDdJVCvLW4fh/vApKORnUgZ V52pfB2uTyzBxtxAfv9Z1LMFAzCwK9auM2rlyqsA8qh9VmqvGce1z4YR0vpzQWfOW/Rs1v k3yVKxvy3pe+CYqJWYnxNiuchhTN5/MR6kaRe18I7aZCFElFPgn2uFt55h4btdCQB0DfhZ xmZu/t3S7rZtA540o6JG/wBc6R6R+80hbQQLytqVcUuTawDZl6YFudmOY2Bssg+RXP2Xlg akqzW7LgAl+x5EZSAXcXqDkEd8pZYNdmiMyMCgqJao9Hyw/Hrp9mqMUDshEsZA== ARC-Authentication-Results: i=1; rspamd-554c8f6c56-94nw7; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Spicy-Coil: 1c2ecadf36ed10e1_1652449360842_3896717200 X-MC-Loop-Signature: 1652449360842:638587292 X-MC-Ingress-Time: 1652449360841 Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.125.123.55 (trex/6.7.1); Fri, 13 May 2022 13:42:40 +0000 Received: from [192.168.86.152] (unknown [103.199.173.7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4L08wH2gpyz1X6; Fri, 13 May 2022 06:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1652449360; bh=R077sYmYX+MRHfsf0PG2TlwSErvHwtTBgCzzlMxdtqA=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=JxzAgFyeSBdTHRlCQ3MDqrE/3pyb/l2Kj67I/cGaYCXXol7IUx2Dxuer3EjLHX4wh ZlpuzIg0JSG12iRdd6UJEVytu40DJIKMmwPUguhxXvjZjuphY4gjJvxbHVZK1Y3FnB ClwA+HrnkQsN3GJxmkPMeMi0bmzHZNHzJqTM3NbNqFQrSvyVs0ckfe4WmXrtCWNPaK a3F1K+gsl9YBFkJC2T1xgxUrIZZaLH1WTUXSt23TNf7knddbnd47M9cm5xzYJgHsrH 1F25PcZkE6BcPo4yt4lAExntHrSfEkABwt9rEV4BtbNlZjzUzCurDKAC+VyNPbkZzB LCipfW8+avSyg== Message-ID: <63c7ffd1-f609-d99a-a2fd-3359bfe7c663@gotplt.org> Date: Fri, 13 May 2022 19:12:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3] wcrtomb: Make behavior POSIX compliant Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20220505184348.3357550-3-siddhesh@sourceware.org> <20220512131503.764504-1-siddhesh@sourceware.org> <4ffe566a-8002-b574-daee-d6927b8ceaef@cs.ucla.edu> <02979241-ff47-ef76-0c77-268aca00c4b8@sourceware.org> <87ilq9d5n2.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 13:42:43 -0000 On 13/05/2022 18:00, Adhemerval Zanella via Libc-alpha wrote: >> Can we please use the simplified code? >> >> “char buf[MB_LEN_MAX];” already gives GCC a strong hint this is a short >> memcpy. If it is beneficial on some architectures to inline such short, >> but still variable memcpy calls, we should teach the compiler how to do >> it, and not do it manually. > > Totally agreed. > Ugh, both of you just kill all the fun. I'll push a fix with just the memcpy ;) Thanks, Siddhesh