From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.cs.ucla.edu (mail.cs.ucla.edu [131.179.128.66]) by sourceware.org (Postfix) with ESMTPS id 02AAF3858C2C for ; Wed, 3 Jan 2024 04:13:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02AAF3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02AAF3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=131.179.128.66 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704255221; cv=none; b=JuSJ583egumjrZC9mDne+fxPiTy3Tk1d4oRy7Z0Dyexk7Rv6yvjfgFgyMinQ6fLvrjiEikp0SvbBf6us8hL6ra1K6KX5PD3LoRojgRC0KFwEPHNqThOmgksEhKBtBkuCpZbAovuCjVhc9RbQvr6FqEIuBm5DYkgRUZOc/gwrNIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704255221; c=relaxed/simple; bh=c3dt4g/A6Hg2zI5TLYcC8N84TXtP97jb5W9UOIfUK8I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MKPjz6PPZ9foS2LuDmzAJ3m5r0MXrmjyvP5U8GSUZIkAM6cCB+5/1kksB/ClMQEjamjgxBcb4p5eSTT6H8BW6JUMR09oQSykrmxNxltFQDBojxmkno43gvrBa/6Msx/MVDap99Ziznr75+zh9RjAw1KGfF3VN+cbCHyv26cP4Lo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 231203C011BD4; Tue, 2 Jan 2024 20:13:30 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id sxsa4aA5UykG; Tue, 2 Jan 2024 20:13:29 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 9C47C3C011BD8; Tue, 2 Jan 2024 20:13:29 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 9C47C3C011BD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1704255209; bh=cFhGf0bk1hXWrjgzPn1SGuOiZ+fRPJiazps3ZGD2r9Q=; h=Message-ID:Date:MIME-Version:To:From; b=bXEyFyAuAl/X4dLo+YFfwcMSnuoYto8rUgJRAFZArCn4tB1s1DHYA00oVQTx7zBaD 1pADxn00SxI02+WvXEe988RAQeAw1V7NW/WU6ukhgT619M8QpPBEJjsmEqWcdeKg7t qv7c8L4ZBoq24x3u/bhWCFTHugShgdIz6mnYPzO2CDyAfDvVDhl7yJq3IMos7IMMpx LWVRH5QeJgjCOzNJ2h8bo0aBriGOJPooEKj+RsRAVmeXvXEn93Yf5U/PCmElB5O2KB G2YOTgSJvnv8LLrdiuulGXDmyjI1NW31w2uCxCTpTT7M4eprWgx9kncb4Z/+9sEwDe 9/8jixZKEJWLQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id qK7ue_m1JqMZ; Tue, 2 Jan 2024 20:13:29 -0800 (PST) Received: from [192.168.254.12] (unknown [47.148.192.211]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 6E8FF3C011BD4; Tue, 2 Jan 2024 20:13:29 -0800 (PST) Message-ID: <63e5e0fc-341d-41fd-a21f-c5928569bd0b@cs.ucla.edu> Date: Tue, 2 Jan 2024 20:13:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, test conversion, RFC] Convert to autoconf 2.72 (no patches) Content-Language: en-US To: Florian Weimer , =?UTF-8?Q?Andreas_K=2E_H=C3=BCttel?= Cc: libc-alpha@sourceware.org References: <2945535.X9hSmTKtgW@noumea> <20240102191743.520137-1-dilfridge@gentoo.org> <874jfvxw23.fsf@oldenburg.str.redhat.com> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <874jfvxw23.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-01-02 13:30, Florian Weimer wrote: > * Andreas K. H=C3=BCttel: >=20 >> @@ -2125,9 +2123,7 @@ struct stat; >> /* Most of the following tests are stolen from RCS 5.7 src/conf.sh. = */ >> struct buf { int x; }; >> struct buf * (*rcsopen) (struct buf *, struct stat *, int); >> -static char *e (p, i) >> - char **p; >> - int i; >> +static char *e (char **p, int i) >> { >> return p[i]; >> } > Is this the critical change? I think so, yes. There are other places where the patch switches from=20 K&R to C89 style, such as the following, but I think these all work with=20 C23 too, even in the unpatched version: /* Override any GCC internal prototype to avoid an error. Use char because int might match the return type of a GCC - builtin and then its argument prototype would still apply. */ -char is_selinux_enabled (); + builtin and then its argument prototype would still apply. + The 'extern "C"' is for builds by C++ compilers; + although this is not generally supported in C code supporting it h= ere + has little cost and some practical benefit (sr 110532). */ +#ifdef __cplusplus +extern "C" +#endif +char is_selinux_enabled (void);