From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 5D7E93857829 for ; Mon, 5 Apr 2021 11:32:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D7E93857829 Received: by mail-ej1-x633.google.com with SMTP id n2so10124150ejy.7 for ; Mon, 05 Apr 2021 04:32:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+PInTMX9m4gaFiNsa6dEglWk2z2F2bXYLasXLkzfQ9A=; b=OqFHgFf2XThadfy/RXm8QXLUQDiVIVRfEVQ1exJAtAd96l58ISetdtsyo4Sl9MKF1w AJX71A/0fTPNcZITt+STkht0H1ir58/iYXdwZUby9FicbEyDgCOg24P0Pic0K34HifuH Lyc+aX1W+GxDVl21/f4p4RVof8QTq3nUtIJQ2vEPnOpamgeA8EQyAs04Z87UXZD5pJZN I97Qqem/BjcCDj3jNgFiLkzabKz/nrleL/Zd4wODQOIiVO0U6B2jd0zd9YKUNCA/fnmA H4iQOzeEIzuqcZBpyQWm5P9+06MlhzIsFomjJKaH5wuvCXkXoR2v0IcHmlanviE5URFu cFXQ== X-Gm-Message-State: AOAM53333C/gubYNbByde1M4oXXRyoNk0Mrc4fikRXfZNUjHLmG4Wxru v9Dto8TdK6vXsoXGEgpfdSiBZ0aVtdw= X-Google-Smtp-Source: ABdhPJySSoQj7S4H956rEPhEvSPyqAage+UouZcaPWIqrw0B3llho4MVh24b2GDLn34+TGvwGkGRnQ== X-Received: by 2002:a17:906:d8a3:: with SMTP id qc3mr5518735ejb.353.1617622337323; Mon, 05 Apr 2021 04:32:17 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id l11sm689763edq.97.2021.04.05.04.32.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:32:17 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v5 13/35] dup.2: SYNOPSIS: Use consistent comments through pages To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-14-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <63ffcfb7-d370-f744-9f9c-eb09e5fe042a@gmail.com> Date: Mon, 5 Apr 2021 13:32:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-14-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 11:32:19 -0000 Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > man2/dup.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks, Michael > diff --git a/man2/dup.2 b/man2/dup.2 > index 725b9d7d5..b9e0828b0 100644 > --- a/man2/dup.2 > +++ b/man2/dup.2 > @@ -45,7 +45,7 @@ dup, dup2, dup3 \- duplicate a file descriptor > .BI "int dup2(int " oldfd ", int " newfd ); > .PP > .BR "#define _GNU_SOURCE" " /* See feature_test_macros(7) */" > -.BR "#include " " /* Obtain O_* constant definitions */" > +.BR "#include " " /* Definition of " O_* " constants */" > .B #include > .PP > .BI "int dup3(int " oldfd ", int " newfd ", int " flags ); > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/