From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id C80213858C55 for ; Tue, 8 Nov 2022 00:06:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C80213858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Content-Type: multipart/signed; boundary="Apple-Mail=_70531AED-CA48-4BF3-AFAD-D1C62551EBAA"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: [PATCH] posix: Make posix_spawn extensions available by default From: Sam James In-Reply-To: <87pmdyiw3x.fsf@oldenburg.str.redhat.com> Date: Tue, 8 Nov 2022 00:05:50 +0000 Cc: Adhemerval Zanella Netto , Carlos O'Donell via Libc-alpha Message-Id: <6423462B-9C7E-40AE-A882-822DF86E1CB6@gentoo.org> References: <875yfv2nsa.fsf@oldenburg.str.redhat.com> <65c25ce3-167b-bb91-bffb-a511d741b12e@linaro.org> <8735ay2a4h.fsf@oldenburg.str.redhat.com> <78b07982-0bee-074a-e491-ab3d844c68f8@linaro.org> <87pmdyiw3x.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: Apple Mail (2.3731.200.110.1.12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_70531AED-CA48-4BF3-AFAD-D1C62551EBAA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 7 Nov 2022, at 16:10, Florian Weimer via Libc-alpha = wrote: >=20 > * Sam James: >=20 >>> On 4 Nov 2022, at 12:26, Adhemerval Zanella Netto via Libc-alpha = wrote: >>>=20 >>>=20 >>>=20 >>> On 04/11/22 09:10, Florian Weimer wrote: >>>> * Adhemerval Zanella Netto: >>>>=20 >>>>> On 04/11/22 04:15, Florian Weimer via Libc-alpha wrote: >>>>>> Some sources merely include without -D_GNU_SOURCE and = expect >>>>>> declarations for posix_spawn_file_actions_addchdir_np to be = available. >>>>>>=20 >>>>>> Tested on x86_64-linux-gnu. >>>>>>=20 >>>>>=20 >>>>> LGTM, although you reference posix_spawn_file_actions_addchdir_np = on commit >>>>> message, but you export posix_spawn_file_actions_addtcsetpgrp_np. >>>>=20 >>>> Sorry, there are multiple functions that are now available by = default. >>>> I encountered the problem just with = posix_spawn_file_actions_addchdir_np, >>>> so I still think the commit message is correct. >>>=20 >>> I would advise cite all the function affected then, because with = only >>> posix_spawn_file_actions_addchdir_np on commit message it might = seems that >>> the patch is exporting more than intended. >>>=20 >>=20 >> Agreed. I'm a little bit uneasy given this ends up masking some >> problems and then we're back to having to only fix them on musl >> systems, but if this is the only function not exposed and the logic >> already applies to the others, I guess it's fine. >=20 > I have submitted a fix to the application as well: >=20 > Build process.c with _GNU_SOURCE > >=20 > But I think the glibc change makes sense independently of that. Alright, WFM. I just ask we keep this consideration in mind for future bits, but the boat has sailed here wrt pthreads. >=20 > Thanks, > Florian best, sam --Apple-Mail=_70531AED-CA48-4BF3-AFAD-D1C62551EBAA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY2mdX18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kCBHAP4wPIsem9ZnlIy5y6N4jgytdnXUy1VGzplI62A9uvCWqAEAlQD1q7wHaASL r89ZRx5P/OVR49cZ9kg4/tMPeZfuww4= =zewm -----END PGP SIGNATURE----- --Apple-Mail=_70531AED-CA48-4BF3-AFAD-D1C62551EBAA--