From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id B56E13852A6B for ; Tue, 13 Dec 2022 03:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B56E13852A6B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32e.google.com with SMTP id x25-20020a056830115900b00670932eff32so3150907otq.3 for ; Mon, 12 Dec 2022 19:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jeh43ZrWCdBdQxZPlxyqjsane5b7HfDBhtzrQR4zLII=; b=bwevmvtf/7UmNDMMsZFYYcuohz2/DLUJCTVTp9owaHjwVmG6GTn1BZFduLdWFBeQqh uPZq4kwgpG4IAQEh934+ZyUEjTW/SdXBsEhxSaBT39tMwUl2nRN70gaGISwDf7mL3+2k qud4uifDM7CeEvxMizIxg+UFqqUxmX/DR/wXKsXEOfSa02FUgFHawpX8Cc36F6r9wE8r 6utGnh1u1OdSG8TZCKXRU/cD0GngncosywcNEjsgSgwHh5aIazEoFKP1N7Kz/PYZXf3p T9BSKnfh5h3Xml5w/cfJFYqJlCmgif48NhXgYaTBKc7cZN1UruMOeblCp8CP+dndVRsj 7cyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jeh43ZrWCdBdQxZPlxyqjsane5b7HfDBhtzrQR4zLII=; b=HG4Q1LJ8fsO5Mhe1uHrHdt+GS3DEFg0QhN2wEh62QbhKmaH7XlWm4yZ311XgaUvgMT 7HN9unOvZVDiJMDogtoODBV8VMMnhXbU0RQQi0Ts8A8SFtr2mCG8pjtNv0mk+TZCM4UV b9JYBfzECJUm+GbTjCG5mO4xJ5AiUIafyIrHjkOUe2yeG/xtKuCCGuZMDfv9BryEJxOe qOmnvai5C2vvD8wmUU44mwna34SEXm3vxtEL7k36c2Kn4ddOR5qdLsD2s8oH4BbKJzKW +TqtYb3tXTJeLVZMfA7/1UIXbRqyT/upXKWweIq4yoyAaTXeZaRJz5FTEkq1R3Z3cYla pXyg== X-Gm-Message-State: ANoB5pnyynTxxUbbOYykmSbuSdFzNUf1UmCqTqx7ke6two/VcGgbnRau HUYAdoGzJC9FzzGny1eSY+AwwjV1QCcX28Wtnlc= X-Google-Smtp-Source: AA0mqf6FPRH9T0cSmTq2023CIPyu9zt6we2oxjrPJxjtbdYyO7/8bnIBHGaSR/u5x1hzqtCh8u3RFA== X-Received: by 2002:a05:6830:6112:b0:661:dfeb:f89a with SMTP id ca18-20020a056830611200b00661dfebf89amr10902019otb.33.1670902035272; Mon, 12 Dec 2022 19:27:15 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:f05e:2901:6544:ce1d:485a? ([2804:1b3:a7c2:f05e:2901:6544:ce1d:485a]) by smtp.gmail.com with ESMTPSA id cy24-20020a056830699800b006619295af60sm685202otb.70.2022.12.12.19.27.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 19:27:14 -0800 (PST) Message-ID: <644e4c13-67fc-deed-6fb1-2fef13bcd5da@linaro.org> Date: Tue, 13 Dec 2022 00:27:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] powerpc64: Increase SIGSTKSZ and MINSIGSTKSZ Content-Language: en-US To: libc-alpha@sourceware.org References: <20221209011652.4109160-1-rajis@linux.ibm.com> <04160486-a48e-38c6-cb70-399ed25fa68f@linux.ibm.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <04160486-a48e-38c6-cb70-399ed25fa68f@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/12/22 20:31, Paul E Murphy via Libc-alpha wrote: > On 12/8/22 7:16 PM, Rajalakshmi Srinivasaraghavan via Libc-alpha wrote: >> This patch increases the value of SIGSTKSZ and MINSIGSTKSZ >> for powerpc64 similar to the kernel commit >> 2f82ec19757f58549467db568c56e7dfff8af283 to allow >> further expansion of the signal stack frame size. > > This LGTM. The kernel's commit message is a little confusing to someone who didn't experience the original issue, but make sense once looking through the tree of referenced commits. Shouldn't powerpc follow x86 to use sysconf (_SC_SIGSTKSZ) as well? Or this is done unconditionally on kernel without it providing a AT_MINSIGSTKSZ? > >> --- >>   sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h | 5 +++++ >>   1 file changed, 5 insertions(+) >> >> diff --git a/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h b/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h >> index abc87cd7a6..4bff1fe1e7 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h >> +++ b/sysdeps/unix/sysv/linux/powerpc/bits/sigstack.h >> @@ -23,10 +23,15 @@ >>   # error "Never include this file directly.  Use instead" >>   #endif >> >> +#ifdef __powerpc64__ >> +#define MINSIGSTKSZ    8192 >> +#define SIGSTKSZ    32768 >> +#else >>   /* Minimum stack size for a signal handler.  */ >>   #define MINSIGSTKSZ    4096 >> >>   /* System default stack size.  */ >>   #define SIGSTKSZ    16384 >> +#endif >> >>   #endif /* bits/sigstack.h */