From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126482 invoked by alias); 28 Oct 2016 18:30:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126360 invoked by uid 89); 28 Oct 2016 18:30:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=HEM3xDauXjVcGY9vr7egoZpNptZmeZ1zH6D0C69TdzY=; b=iJi+UKZqBlfe3n6ZcBXtVa1E21QRyuM9Cb8ro1PLRLxoVXcUq++Kt5GLns1BNapZFM iKpDQryI2UR/JJ9hN6r+WUmG2pbV/uqrYDtBolkM4mum3Gcq4SL7fPchnAnNOUKVslf7 U5Q1u7td6n1TdND/tPLG7eXVvT6h9/Q+A8bbhB4UO4x3N/MunjcypmrUHwyJIAkadF2m fJzcb4bZVnS6RdlG8cE0dKT2Ysx4ORjQGL6ciuk9ShziXVF3wYWKnN/9dqwEsHLP+oOB lXpwjAOMnlG6UhXJuTjIbu+p/pl5TbW9u+8+EMRmNkb3+d0tOwtHjMkHRLiOTudy22Rc 485Q== X-Gm-Message-State: ABUngve1Ul1gh6FnFbS9aRFffzeLX5hCR0Gdo32ckG4gRsW96gUeGr3h2tOuE2P0ON6VPqpp X-Received: by 10.55.68.73 with SMTP id r70mr11410246qka.277.1477679407103; Fri, 28 Oct 2016 11:30:07 -0700 (PDT) Subject: Re: [PATCH] Add test for linking against most static libraries To: Joseph Myers References: <20161028125742.928D7439942E0@oldenburg.str.redhat.com> <8b17140d-bbab-95c1-7458-7214f0e474ad@redhat.com> <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com> Cc: Florian Weimer , libc-alpha@sourceware.org From: Carlos O'Donell Message-ID: <64653efd-c294-f544-685d-48e1cafa51a9@redhat.com> Date: Fri, 28 Oct 2016 18:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00561.txt.bz2 On 10/28/2016 01:33 PM, Joseph Myers wrote: > On Fri, 28 Oct 2016, Carlos O'Donell wrote: > >> I'm kinda baffled by this. We don't set it in config-sysdirs. >> >> I expect you have a local patch that hid this. > > I expect he happened to have a compiler that searched a system include > directory with crypt.h. > >> I'm going to commit the following immediate fix: >> >> 2016-10-28 Carlos O'Donell >> >> * elf/Makefile (CFALGS-tst-linkall-static): Define. > > That's not the right fix. The right way to address such issues is a > wrapper header in include/. OK, I'll fix it that way right now. -- Cheers, Carlos.