From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id B8627395C04A for ; Wed, 2 Jun 2021 14:43:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8627395C04A Received: by mail-qk1-x72b.google.com with SMTP id q10so2574691qkc.5 for ; Wed, 02 Jun 2021 07:43:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=71/E3QIgXjC2iy7usschcXTMxSwfT65y8v6K/mgE2bI=; b=fOXCKEpCQ2cvvXGikzt/8O8We2P64MZYn/h8wBqeNOWdVXCcTjkP/RLAgRAs2M6Tmt ufK7Vnzrm2OlnahpE9KM+K1fcNa01T0FNGDBNMQA3vCMsyuyIPiWWj8JaM+NaBWAyAs+ Cev57ngv2Z6rlSMNg6LYR8pLNA5fFBjKw10Sd0RyFc8/38yYiM/r23EJfO57PjDuVj4f +aD/Lmz4tz4nz+qOW4FzyEj7kJ2ibyJYBvOuJB0H1XQBjHHS2NyCjpkPMx6n1yv1XlsW 2b3eUUlp/CrzNFWH24fb3x/ctHwM00JpwpFLw1kNourMiosnKd9qEs15B9OuuHgB2o7U faPw== X-Gm-Message-State: AOAM533HAnUIB2QGrovN0xKaprTN8Fhp9OnU8f3YuFFoNRfXeOl7B2LX Uw0tAtLnS5SGzPq13LRjmomLSDFIVxidcw== X-Google-Smtp-Source: ABdhPJwz2bLKSRr2MR4Xqx2lIapBYzHqsRNV6m3lNtVasHa2PkUOgk+s1NoMiAkdptC7x1dBcqqd1Q== X-Received: by 2002:a05:620a:13d5:: with SMTP id g21mr27848759qkl.494.1622644995295; Wed, 02 Jun 2021 07:43:15 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id h3sm86799qkk.82.2021.06.02.07.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 07:43:15 -0700 (PDT) Subject: Re: [PATCH 09/16] dlfcn: Move dlmopen into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <59a14fc491a58520936da8d69093abf9112a7ffe.1622469908.git.fweimer@redhat.com> <477ae2c4-40ef-a74a-1150-6761b1c7099a@linaro.org> <874kegz61c.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <6473f6f2-3aae-9565-08a0-3e74fd26a9cf@linaro.org> Date: Wed, 2 Jun 2021 11:43:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <874kegz61c.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 14:43:26 -0000 On 02/06/2021 11:37, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 31/05/2021 11:12, Florian Weimer via Libc-alpha wrote: >>> The symbol was moved using scripts/move-symbol-to-libc.py. >> >> LGTM, thanks. I would move the compat symbols at dlfcn/dlfcn.c to >> a dlfcn/libdl-compat.c, similar to what is done for libpthread. > > I'm going to rename the file in the final cleanup patch, where > dlfcn/dlfcn.c is otherwise empty. > Fair enough.