public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: "Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v16] POSIX locale covers every byte [BZ# 29511]
Date: Wed, 12 Jul 2023 23:49:59 +0200	[thread overview]
Message-ID: <6497083.JsnAkG3lO3@nimes> (raw)

Some more comments:

* The encoding name "POSIX" is available as nl_langinfo (CODESET). Many
  applications pass this encoding name to iconv(1) or iconv_open(3);
  this is the main purpose of knowing the locale's encoding, after all.

  But if musl libc, or any other libc (Solaris or whatever), does the
  same thing, but with a different mapping table than glibc has,
  iconv implementations have a problem, because the name "POSIX" then
  has different mapping tables on different systems. Basically, it will
  be the BIG5 mess reloaded. [1]

  Suggestion: Change the encoding name from "POSIX" to "POSIX-GNU" or
  something similar, to make it possible for iconv implementations to
  support it in a future-proof way.

* The identifier __gconv_btwoc_posix looks misspelled.
  Suggestion: s/__gconv_btwoc_posix/__gconv_btowc_posix/
  (The previous one, __gconv_btwoc_ascii, is misspelled as well.)

* iconv/gconv_int.h: In the comment

   identity-mapping bytes [0, 0x7F], and moving [0x80, 0xFF] into the end
   of the Low Surrogate Area at [U+DC80, U+DCFF].  */

  it's no longer the end of the Low Surrogate Area [U+DC00, U+DFFF].
  Suggestion: Change the comment to

   identity-mapping bytes [0, 0x7F], and mapping [0x80, 0xFF] into the
   Low Surrogate Area at [U+DC80, U+DCFF].  */

Bruno

[1] https://haible.de/bruno/charsets/conversion-tables/Big5.html




             reply	other threads:[~2023-07-12 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 21:49 Bruno Haible [this message]
2023-07-12 23:51 ` наб
  -- strict thread matches above, loose matches on Subject: below --
2023-07-12 19:44 Bruno Haible
2023-07-12 20:22 ` наб
2023-07-12 21:08   ` Bruno Haible
2023-07-03 15:39 наб

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6497083.JsnAkG3lO3@nimes \
    --to=bruno@clisp.org \
    --cc=libc-alpha@sourceware.org \
    --cc=nabijaczleweli@nabijaczleweli.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).