From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 0/4] Do not install shared objects under versioned names
Date: Sun, 27 Jun 2021 17:31:56 -0400 [thread overview]
Message-ID: <64e0b16e-92bb-742a-ffe0-fa134c6c242e@redhat.com> (raw)
In-Reply-To: <cover.1623312996.git.fweimer@redhat.com>
On 6/10/21 4:22 AM, Florian Weimer via Libc-alpha wrote:
> This is essentially a repost of the “Add --disable-major-minor-libraries
> configure option” series. Joseph suggested that the configure option is
> not needed, so this version implements the change unconditionally.
This is absolutely the right direction.
I like that we simplify the layout.
I have commented on Siddhesh's thoughts in the other thread, and I think
we are never likely to implement a solution that installs parallel libcs
given the QE and container aspects.
Therefore I'd like to see this move forward.
> Tested on i686-linux-gnu and x86_64-linux-gnu. I compared two
> build-many-glibcs.py trees with and without these patches, using this
> command to see if there are missing files besides the versioned DSOs or
> any dangling symbolic links.
>
> cd /home/bmg/install/glibcs && find -printf '%P\n' \
> | while read x ; do
> test -r /home/bmg-install-glibcs/$x || echo $x
> done \
> | grep -v '\-2\.33\.9000\.so$' | grep -v '/libthread_db-1\.0\.so$'
>
> /home/bmg/install/glibcs is the unpatched build,
> /home/bmg-install-glibcs is the build with the patches applied. As
> expected, there was no output.
>
> Thanks,
> Florian
>
> Florian Weimer (4):
> nptl_db: Install libthread_db under a regular implementation name
> Makerules: Remove lib-version, $(subdir-version)
> elf: Generalize name-based DSO recognition in ldconfig
> Install shared objects under their ABI names
>
> INSTALL | 10 +++++++
> Makefile | 6 ----
> Makerules | 67 +++++----------------------------------------
> NEWS | 8 ++++++
> elf/Makefile | 12 ++------
> elf/dl-is_dso.h | 33 ++++++++++++++++++++++
> elf/ldconfig.c | 5 ++--
> elf/tst-dl-is_dso.c | 35 +++++++++++++++++++++++
> nptl_db/Makefile | 2 --
> 9 files changed, 98 insertions(+), 80 deletions(-)
> create mode 100644 elf/dl-is_dso.h
> create mode 100644 elf/tst-dl-is_dso.c
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2021-06-27 21:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:22 Florian Weimer
2021-06-10 8:23 ` [PATCH 1/4] nptl_db: Install libthread_db under a regular implementation name Florian Weimer
2021-06-27 21:32 ` Carlos O'Donell
2021-06-10 8:23 ` [PATCH 2/4] Makerules: Remove lib-version, $(subdir-version) Florian Weimer
2021-06-27 21:32 ` Carlos O'Donell
2021-06-10 8:23 ` [PATCH 3/4] elf: Generalize name-based DSO recognition in ldconfig Florian Weimer
2021-06-27 21:32 ` Carlos O'Donell
2021-06-10 8:23 ` [PATCH 4/4] Install shared objects under their ABI names Florian Weimer
2021-06-27 21:32 ` Carlos O'Donell
2021-06-14 11:04 ` [PATCH 0/4] Do not install shared objects under versioned names Florian Weimer
2021-06-14 14:49 ` Siddhesh Poyarekar
2021-06-27 20:43 ` Carlos O'Donell
2021-06-28 3:42 ` Siddhesh Poyarekar
2021-06-27 21:31 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e0b16e-92bb-742a-ffe0-fa134c6c242e@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).