From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 6F4443858D37 for ; Thu, 25 May 2023 11:06:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F4443858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1685012815; bh=vBrkkO1qHbYvvEM766TUGzx+aMQwydRqDhnxDnr37Vc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XlsFCM7SdnNvGfRRow0Jc1x7Kv3ZQsBPkL03l3cWYC4uoYyqR7ATwpHEKGJxv/OtX +UlGw7B7RDvmzXzqMd0/n/rNmuJcEpDKF1TNHCqgqJd1EvWMlJjdrQC296rbcZWvta aUI/sQtArcKU52YORVoBVf05hLX5zg/ev+KRKrbc= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 3FC6D66359; Thu, 25 May 2023 07:06:37 -0400 (EDT) Message-ID: <6502af9a1ff67f37663039d5d78e396816088bde.camel@xry111.site> Subject: Re: [PATCH] LoongArch: Fix inconsistency in SHMLBA macro values between glibc and kernel From: Xi Ruoyao To: Florian Weimer , caiyinyu Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org, lixing@loongson.cn Date: Thu, 25 May 2023 19:05:54 +0800 In-Reply-To: <87zg5sllnj.fsf@oldenburg.str.redhat.com> References: <20230525103217.314605-1-caiyinyu@loongson.cn> <87zg5sllnj.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-05-25 at 13:01 +0200, Florian Weimer wrote: > > The LoongArch glibc was using the value of the SHMLBA macro from > > common code, > > which is __getpagesize() (16k), but this was inconsistent with the > > value of > > the SHMLBA macro in the kernel, which is SZ_64K (64k). This caused > > several > > shmat-related tests in LTP (Linux Test Project) to fail. This commit > > fixes > > the issue by ensuring that the glibc's SHMLBA macro value matches > > the value > > used in the kernel like other architectures. >=20 > Would it be possible to add a generic test like > sysdeps/unix/sysv/linux/tst-mman-consts.py against the UAPI headers? > Or is this constant not exported at all? SHMLBA seems not exist in a Linux 6.3.0 UAPI header installation (from Gentoo on a LoongArch). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University