public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: Andreas Schwab <schwab@suse.de>, libc-alpha@sourceware.org
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] elf: correct relocation statistics for !ELF_MACHINE_START_ADDRESS
Date: Mon, 29 Jan 2024 21:39:31 +0100	[thread overview]
Message-ID: <6590347.G0QQBjFxQf@pinacolada> (raw)
In-Reply-To: <7ae346cd-43bd-492e-a0a5-04d882a8217e@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Am Montag, 29. Januar 2024, 18:22:10 CET schrieb Adhemerval Zanella Netto:
> 
> On 29/01/24 13:03, Andreas Schwab wrote:
> > Fixes: 6628c742b2 ("elf: Remove prelink support")
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 

Is that a fix that should still go into the release? If yes, 
please confirm...

> > ---
> >  elf/rtld.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/elf/rtld.c b/elf/rtld.c
> > index 4f494b792e..ac4bb23652 100644
> > --- a/elf/rtld.c
> > +++ b/elf/rtld.c
> > @@ -2815,10 +2815,9 @@ print_statistics (const hp_timing_t *rtld_total_timep)
> >  	    num_relative_relocations
> >  	      += l->l_info[VERSYMIDX (DT_RELCOUNT)]->d_un.d_val;
> >  #ifndef ELF_MACHINE_REL_RELATIVE
> > -	  /* Relative relocations are processed on these architectures if
> > -	     library is loaded to different address than p_vaddr.  */
> > -	  if ((l->l_addr != 0)
> > -	      && l->l_info[VERSYMIDX (DT_RELACOUNT)])
> > +	  /* Relative relocations are always processed on these
> > +	     architectures.  */
> > +	  if (l->l_info[VERSYMIDX (DT_RELACOUNT)])
> >  #else
> >  	  /* On e.g. IA-64 or Alpha, relative relocations are processed
> >  	     only if library is loaded to different address than p_vaddr.  */
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

  reply	other threads:[~2024-01-29 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 16:03 Andreas Schwab
2024-01-29 17:22 ` Adhemerval Zanella Netto
2024-01-29 20:39   ` Andreas K. Huettel [this message]
2024-01-29 20:48     ` Andreas K. Huettel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6590347.G0QQBjFxQf@pinacolada \
    --to=dilfridge@gentoo.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).