Monday Patch Queue Review update (2021-09-27)

Monday Patch Queue Review update (2021-09-27)

[Carlos O'Donell]

Most recent meeting status is always here:
https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update

Meeting: 2021-09-27 @ 0900h EST (UTC-5)

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

 * LPC: GNU Tools track Glibc BoF identified we should review more patches.
 * 365 patches in the NEW/NOBODY queue.
 * 45462: [PING,5] localedata: add new locale ab_GE
   * Need to review the reviewers position on copyright/license text.
   * https://sourceware.org/pipermail/libc-alpha/2021-September/130692.html
 * 45457: linux: Fix a non-constant expression in _Static_assert
   * Accepted. Under review from Paul Eggert.
 * [v1,1/3] benchtests: Add medium cases and increase iters in bench-memset.c 
   * Should be looked at by H.J. for correctness.
   * Results attached. Look OK.
 * 45437 [powerpc] Fix unrecognized instruction errors with recent binutils
   * Is this a binutils bug?
   * Paul should commit. What review is he expecting?
 * 45436 puts: indentation
   * Florian to follow up.
 * 45434 pthread/tst-cancel28: Fix barrier re-init race condition
   * Adhemerval has this on his list.
 * 45430 elf: Add __libc_get_static_tls_bounds [BZ #16291]
   * Outstanding question from Florian.
 * 45429 [v3] elf: Avoid nested functions in the loader (all ports) [BZ #27220]
   * Complexity looks reasonable.
   * No global data introduced.
   * Should we test on hppa and ia64?
   * Florian: Will test ia64.
   * Adhemerval: Will test hppa.
 * Down to 344 patches.
 * 45423 Disable symbol hack in libc_nonshared.a
   * Florian to ACK. Agreement that it looks correct.
 * 45422 [v2] i386: Port elf_machine_{load_address,dynamic} from x86-64
   * Accepted by HJ
 * 45407 powerpc: Delete unneeded ELF_MACHINE_BEFORE_RTLD_RELOC
   * Accepted by Rafael
 * Break to review status from meeting participants.
 * Siddhesh: Inputs to math benchmarks?
   * Paul Z. wanted to add an extra sets.
   * Agreed that workloads could be added.
 * 44622 [v3] Fixed inaccuracy of j0f (BZ #28185)
   * Carlos to review.
 * Patrick: Recommend that new users should login to patchwork because
   you can't set your settings until you have a login.
   * Carlos will amend wiki with notes.
 * Patrick: Is OFTC #glibc used for hte review meeting?
   * Carlos: It can be used if you want. It is the official IRC, and we will
     discuss patch review via IRC.
 * Florian: 3 things to raise.
   * opensock problem with the race.
     * 4 address families, and remove unused code.
   * recvmsg emulation code is non-functional for time64
     * systemd/qemu reported problem.
     * Some callers expect you can use a very tightly sized buffer.
     * Not enough space and this breaks.
     * See: https://sourceware.org/bugzilla/show_bug.cgi?id=28350
     * See: https://sourceware.org/bugzilla/show_bug.cgi?id=13500
   * getaddrinfo crash, dns related, reported on launchpad tracker.
     * There are no packet captures.
     * Looks like a real problem.
     * https://bugs.launchpad.net/bugs/1945072
 * Adhemerval:
   * Audit patch set: Carlos: Yes, trying to get reviews.
   * sort: https://patchwork.sourceware.org/project/glibc/list/?series=2745
     * What do we do about malloc?
     * Change in algorithm?
       * Yes, the performance is different.
       * We use quicksort instead of mergesort.
       * Use intrasort to avoid quadratic worse case.
     * https://sourceware.org/pipermail/libc-alpha/2021-September/130698.html
   * Looking for comments on the series.

-- 
Cheers,
Carlos.