From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9DD313858D3C for ; Mon, 27 Sep 2021 14:22:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DD313858D3C Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-v6nnESQ4N22-nveF_ZrY_g-1; Mon, 27 Sep 2021 10:22:02 -0400 X-MC-Unique: v6nnESQ4N22-nveF_ZrY_g-1 Received: by mail-qk1-f199.google.com with SMTP id w2-20020a3794020000b02903b54f40b442so75001270qkd.0 for ; Mon, 27 Sep 2021 07:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject:organization :content-transfer-encoding; bh=EfZESsI+3lTTXVC9Kw1xrQCYVLyQd03k1w6eexdA67c=; b=co+xRY4GuOtE5IQHCnER9Y/9y8DuYfPVr302S7kDXIbT2rCrY0stjJlkipMyqqeFnl 8H5K3U/a3ITZ+s3w2vqPlpAKIdxPwNn12qAHtD76anigV84mOSiJB+9pabtOUpqgigtk MPEyA5x2tdNG9BIthJn8oBfnWz/Raj9PDB1WXuMT6vqAY0su1/EbC3471Kgel4VRm+jq 37Jypi85gb7lzQ45CSFoxBCcVnL0kKeWf2lbgGcile+TQs3HgmNlKKZjdBcF3RZyA+5I WGZJg1xi/62Sa84q530Jy7b+5KS8EBEL26MpVvXmobbefubwO11G5hfnjxT5lqIKRdAp 9flg== X-Gm-Message-State: AOAM5319RnEzUDE3pDIMRU9Zu/O89xKSKodrI/4gYMJddpg8RT3qblIp ZiNbDL509XILDE2qIGeA7rbZQ2WS5rEdThIea5GldzhihFrbqV7lSt7p34sBqZHNEj9usEw/fFO xmicANlcj+z/PBDcNIHMiNr842aXB16aaPliL34jXsCkeNgQGvaFT2fvSl05LYnbCDlzrAA== X-Received: by 2002:a0c:b391:: with SMTP id t17mr33080qve.35.1632752518388; Mon, 27 Sep 2021 07:21:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCir7Vc8BYu2Zo0l6qBjePCcfu0MXn5xETpSRgijo8nlhfeTeYqqyEgsRyNuD26q+ZpRuJxQ== X-Received: by 2002:a0c:b391:: with SMTP id t17mr32413qve.35.1632752509462; Mon, 27 Sep 2021 07:21:49 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id t23sm12947308qkj.31.2021.09.27.07.21.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 07:21:48 -0700 (PDT) Message-ID: <65aafcd1-9792-745e-8c5c-b3363cc6d3a7@redhat.com> Date: Mon, 27 Sep 2021 10:21:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: libc-alpha From: Carlos O'Donell Subject: Monday Patch Queue Review update (2021-09-27) Organization: Red Hat X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 14:22:07 -0000 Most recent meeting status is always here: https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update Meeting: 2021-09-27 @ 0900h EST (UTC-5) Video/Audio: https://bluejeans.com/9093064454 IRC: #glibc on OFTC. Review new patches and restart review at the top. * LPC: GNU Tools track Glibc BoF identified we should review more patches. * 365 patches in the NEW/NOBODY queue. * 45462: [PING,5] localedata: add new locale ab_GE * Need to review the reviewers position on copyright/license text. * https://sourceware.org/pipermail/libc-alpha/2021-September/130692.html * 45457: linux: Fix a non-constant expression in _Static_assert * Accepted. Under review from Paul Eggert. * [v1,1/3] benchtests: Add medium cases and increase iters in bench-memset.c * Should be looked at by H.J. for correctness. * Results attached. Look OK. * 45437 [powerpc] Fix unrecognized instruction errors with recent binutils * Is this a binutils bug? * Paul should commit. What review is he expecting? * 45436 puts: indentation * Florian to follow up. * 45434 pthread/tst-cancel28: Fix barrier re-init race condition * Adhemerval has this on his list. * 45430 elf: Add __libc_get_static_tls_bounds [BZ #16291] * Outstanding question from Florian. * 45429 [v3] elf: Avoid nested functions in the loader (all ports) [BZ #27220] * Complexity looks reasonable. * No global data introduced. * Should we test on hppa and ia64? * Florian: Will test ia64. * Adhemerval: Will test hppa. * Down to 344 patches. * 45423 Disable symbol hack in libc_nonshared.a * Florian to ACK. Agreement that it looks correct. * 45422 [v2] i386: Port elf_machine_{load_address,dynamic} from x86-64 * Accepted by HJ * 45407 powerpc: Delete unneeded ELF_MACHINE_BEFORE_RTLD_RELOC * Accepted by Rafael * Break to review status from meeting participants. * Siddhesh: Inputs to math benchmarks? * Paul Z. wanted to add an extra sets. * Agreed that workloads could be added. * 44622 [v3] Fixed inaccuracy of j0f (BZ #28185) * Carlos to review. * Patrick: Recommend that new users should login to patchwork because you can't set your settings until you have a login. * Carlos will amend wiki with notes. * Patrick: Is OFTC #glibc used for hte review meeting? * Carlos: It can be used if you want. It is the official IRC, and we will discuss patch review via IRC. * Florian: 3 things to raise. * opensock problem with the race. * 4 address families, and remove unused code. * recvmsg emulation code is non-functional for time64 * systemd/qemu reported problem. * Some callers expect you can use a very tightly sized buffer. * Not enough space and this breaks. * See: https://sourceware.org/bugzilla/show_bug.cgi?id=28350 * See: https://sourceware.org/bugzilla/show_bug.cgi?id=13500 * getaddrinfo crash, dns related, reported on launchpad tracker. * There are no packet captures. * Looks like a real problem. * https://bugs.launchpad.net/bugs/1945072 * Adhemerval: * Audit patch set: Carlos: Yes, trying to get reviews. * sort: https://patchwork.sourceware.org/project/glibc/list/?series=2745 * What do we do about malloc? * Change in algorithm? * Yes, the performance is different. * We use quicksort instead of mergesort. * Use intrasort to avoid quadratic worse case. * https://sourceware.org/pipermail/libc-alpha/2021-September/130698.html * Looking for comments on the series. -- Cheers, Carlos.