From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 28CD03858D38 for ; Fri, 4 Nov 2022 12:04:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28CD03858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13be3ef361dso5241811fac.12 for ; Fri, 04 Nov 2022 05:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K9Ze8lPOvUp97TpSdu7ur2R/ERC9kxYBAq9Ti1lhQcg=; b=P/XiKlw1iAaot2ItfEsbRSB0/VZs9OQ9SBduNDkeIer5AqYMT4coX+ftbLsBw47BwR M8czSfmsj81Wi+L/wFcdmJ2xlicsSDdYzU3SZfjh/pyXLKoNtjbduzZg7ztQCKhljRMF 323g+DZG4UGhhPFKOQ2c3kJNBhxKWrzKhbn0R4G/8vLVFtfXXpfMuvquaLAUBvrNH2yV p2ncdVXSCDLa9fxQqEP5IefGNxj1vbEv8YWKkt3ekotxYfRMf1J3vGohrnALRDsE9Y51 Zs5bCcKfRXKVpulGZXqZlyqkYbY/my3r+gfntYq+swmVKakGjoJNIsmgim/PIJMY/Ar8 2JIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K9Ze8lPOvUp97TpSdu7ur2R/ERC9kxYBAq9Ti1lhQcg=; b=EBBy1214jLC3N4rwvdePdvl4wkv7w3aAw/UPNPC36fPjFO2QW39RyM98Zz7VRQxSt3 sqaGPz0wcri8ry6ZLHESn+qRtavf+eiJAA6owfTWr7FoL54UXKQejp7unUARewGzAZYR 4L+vfGdlzmsATISwLXwLN+lnTEObyVwNQ9GOODxr1zdiuv8CCbRABkGVG/gzVACPehML jtU/JeghLLOiVzYeubVLAMcKW7xFy1DIi9IjSs0BkAqX7WKQu7WhABN5RdfPCUE+80nU r3NzRx+dK6k51c4KDa7NfNc+jEkvRpJBVZz1N49g5TFQQkzBbzci8k5FCoph7fd5OV9+ IBFg== X-Gm-Message-State: ACrzQf0U1dnZYS5Fc5ed3clhYV2gFlBiGqTo7M+8WUz7ydNOTVF+J/3O RkzAOKUt/AmFfwWz12mBI9c6AQ== X-Google-Smtp-Source: AMsMyM7MB/53I9CG3VlJkpwiBnm8AqrYQqLJawwYFauPsyAVG2F4gM2t3eKMUfDUIw24CAPHnQwBdg== X-Received: by 2002:a05:6870:4585:b0:12c:d9dc:1141 with SMTP id y5-20020a056870458500b0012cd9dc1141mr21321969oao.219.1667563447358; Fri, 04 Nov 2022 05:04:07 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:a9f4:4405:8c19:a65e:e640? ([2804:1b3:a7c0:a9f4:4405:8c19:a65e:e640]) by smtp.gmail.com with ESMTPSA id q130-20020aca4388000000b00354b0850fb6sm1339683oia.33.2022.11.04.05.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 05:04:06 -0700 (PDT) Message-ID: <65c25ce3-167b-bb91-bffb-a511d741b12e@linaro.org> Date: Fri, 4 Nov 2022 09:04:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] posix: Make posix_spawn extensions available by default Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <875yfv2nsa.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <875yfv2nsa.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04/11/22 04:15, Florian Weimer via Libc-alpha wrote: > Some sources merely include without -D_GNU_SOURCE and expect > declarations for posix_spawn_file_actions_addchdir_np to be available. > > Tested on x86_64-linux-gnu. > LGTM, although you reference posix_spawn_file_actions_addchdir_np on commit message, but you export posix_spawn_file_actions_addtcsetpgrp_np. > --- > posix/spawn.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/posix/spawn.h b/posix/spawn.h > index c4a81227b0..f3bcbc56be 100644 > --- a/posix/spawn.h > +++ b/posix/spawn.h > @@ -198,7 +198,7 @@ extern int posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t * > int __fd, int __newfd) > __THROW __nonnull ((1)); > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > /* Add an action changing the directory to PATH during spawn. This > affects the subsequent file actions. */ > extern int posix_spawn_file_actions_addchdir_np (posix_spawn_file_actions_t * > @@ -227,7 +227,7 @@ posix_spawn_file_actions_addtcsetpgrp_np (posix_spawn_file_actions_t *, > int __tcfd) > __THROW __nonnull ((1)); > > -#endif > +#endif /* __USE_MISC */ > > __END_DECLS > > > base-commit: faaf733f49211439475e50f06716b303ee2644bf >