From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 9FBC63857340 for ; Tue, 11 Jun 2024 19:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FBC63857340 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FBC63857340 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718134101; cv=none; b=GCHEMLq+n/oOiqJtxr7/TQykM44fVyuD2xJwpMQUKUSkCMXa1qP6offiraUzLlLPbKOprdJ8SFOaNGGVznxYI+FXUv/MZUmvZaizB6l5POj/RPx+gqRx3A4uGtS657AiaGUcXJor+K7qG1FQ0PuwPjCj7V8fwbaZ99AnGc9WiVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718134101; c=relaxed/simple; bh=3zylspW3JdHfxvPC7AgqgTcObX4fOIVOsF/o/mst9Jo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=lJTonre3KZc8hZIgdBO+EDE1d9VomxxI1Fj3oCfrXMKKLt17xfUA3PxZASirW4GG6Fu5HeShMeA9r9HUA4GxhZM8ZL5fiKGLIZSXJ0g4EB4RPkgCsFNnTF2xUZRUTWFLhSQQW8NE3nWl8in3ujWRtQceZnVz8O/RYNAmo4v5HHA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1f717608231so17760675ad.2 for ; Tue, 11 Jun 2024 12:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718134098; x=1718738898; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=SYjOScE3B6f3+LLoHM2ET1loI+ybXOv2qSYOa2NaxpU=; b=z6yX031RyJY0k/w/aaVSyjC/BbbgZGZC7TMFeP/4x0DKX7iEkWyNZOx5hriaN/5f7k XLDbWnY0nREy3EUpWtvneI73pFiLx4a1jlsxiKuWIZ+aG5p45tYMP08Agh3R4myBIWav p1F/1S5fsO1gcdxrBMCM6cbmaxBiJZC+vgYGNbbDXPd4J/iG4edIB/CvKzy/zOX84r5k 1PGQiuVlE+205KTzxNmyREom/9f7vV9DwSXg6UwkumN2108SsjqsGw6tLxa36+ljNiaC LTA9u5y2GghbnKY2WkeCrqi2rK5ivKkhweauicPrjWjmiSKBr1GFgOEKMbJaqOmn3x2D k/Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718134098; x=1718738898; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SYjOScE3B6f3+LLoHM2ET1loI+ybXOv2qSYOa2NaxpU=; b=htaJjKbaeclI9ojiNV1fDb7t94no6KhGbC/dnW7NlALp5+VNWG5/gVmthv9iztI1hi F+Yi1620LPsqaIeVdgrmb/vfQmsLZKGxIOI3ayo4w2r0IJgpA7BlxMqmnr0A+jfXP76V OfX3q+IQ8BIgsq5WT9hFE3SxewLGv0E1NUDizsTd7Y/fDpN5iiq9NdDZA6usfgVK69AZ 3JPhN0tRjv1oqt9cFD9Ee6lALLCOcz8BEC8QuWT0dld5CmJ/I4a3izin3G4MA0zTFOx4 fZvAF+bqa9Edj9V1GmGMIzyv+AGwvvutvkl3UkfVZeZqXvJrorstUbYq9+5FgkFuKI5M 4ADw== X-Forwarded-Encrypted: i=1; AJvYcCXTut59c+AFrRdyd4aDaHOIHvcVfnq7AwnN6rXMYcnOt+CXYEB5XotI9TXXTRZGZLwNrnDqyF2MbTc6+H7RceeVVgqMN3lM2jqn X-Gm-Message-State: AOJu0YzGpIab/o6QUm9ITckAUrAPQ9OtBr0Rf78ZG8OJgbd8hU0iLzAE 1ID+POBmzabs4x2u8QzN81J5li/Lw1GK3Dx6SPUhzOCTKUvr+0ygURC7rBq5tPU= X-Google-Smtp-Source: AGHT+IElPexVNQf8FMqO/R+6Cu3JoeYDyRAY9HSEAk/yS3gnMAzHDaMfRwrpNO2DnwdBlumosRf+wg== X-Received: by 2002:a17:902:f550:b0:1f6:1f90:987a with SMTP id d9443c01a7336-1f6d02c8ff4mr165582785ad.3.1718134098533; Tue, 11 Jun 2024 12:28:18 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c5fb:e1da:f9b7:66da:199? ([2804:1b3:a7c0:c5fb:e1da:f9b7:66da:199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f71b9dec2bsm35809115ad.186.2024.06.11.12.28.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 12:28:17 -0700 (PDT) Message-ID: <65cd8479-a226-4d8c-ad84-5da02802e49d@linaro.org> Date: Tue, 11 Jun 2024 16:28:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 5/9] elf: Remove _DL_HWCAP_PLATFORM To: Stefan Liebler , libc-alpha@sourceware.org Cc: fweimer@redhat.com, devel@otheo.eu, bergner@linux.ibm.com References: <20240607114543.659306-1-stli@linux.ibm.com> <20240607114543.659306-6-stli@linux.ibm.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240607114543.659306-6-stli@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/06/24 08:42, Stefan Liebler wrote: > Remove the definitions of _DL_HWCAP_PLATFORM as those are not used > anymore after removal in elf/dl-cache.c:search_cache(). LGTM, thanks Reviewed-by: Adhemerval Zanella > --- > sysdeps/alpha/dl-procinfo.h | 3 --- > sysdeps/csky/dl-procinfo.h | 2 -- > sysdeps/generic/dl-procinfo.h | 3 --- > sysdeps/mips/dl-procinfo.h | 3 --- > sysdeps/powerpc/dl-procinfo.h | 3 --- > sysdeps/s390/dl-procinfo.h | 3 --- > sysdeps/sparc/dl-procinfo.h | 3 --- > sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h | 3 --- > sysdeps/unix/sysv/linux/arm/dl-procinfo.h | 3 --- > sysdeps/x86/dl-procinfo.h | 3 --- > 10 files changed, 29 deletions(-) > > diff --git a/sysdeps/alpha/dl-procinfo.h b/sysdeps/alpha/dl-procinfo.h > index bc4db868a9..90f83ec24e 100644 > --- a/sysdeps/alpha/dl-procinfo.h > +++ b/sysdeps/alpha/dl-procinfo.h > @@ -22,9 +22,6 @@ > #include > > > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (-1ULL) > - > #define _DL_PLATFORMS_COUNT 5 > > /* We cannot provide a general printing function. */ > diff --git a/sysdeps/csky/dl-procinfo.h b/sysdeps/csky/dl-procinfo.h > index a54e8de446..803441f52c 100644 > --- a/sysdeps/csky/dl-procinfo.h > +++ b/sysdeps/csky/dl-procinfo.h > @@ -22,8 +22,6 @@ > > #include > > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (-1ULL) > > #define _DL_PLATFORMS_COUNT 4 > > diff --git a/sysdeps/generic/dl-procinfo.h b/sysdeps/generic/dl-procinfo.h > index 00e1ae7b2f..1778fd1057 100644 > --- a/sysdeps/generic/dl-procinfo.h > +++ b/sysdeps/generic/dl-procinfo.h > @@ -28,9 +28,6 @@ > /* By default there is no important hardware capability. */ > #define HWCAP_IMPORTANT (0) > > -/* There're no platforms to filter out. */ > -#define _DL_HWCAP_PLATFORM 0 > - > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > diff --git a/sysdeps/mips/dl-procinfo.h b/sysdeps/mips/dl-procinfo.h > index 3199434390..7185542eac 100644 > --- a/sysdeps/mips/dl-procinfo.h > +++ b/sysdeps/mips/dl-procinfo.h > @@ -22,9 +22,6 @@ > #include > > > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (-1ULL) > - > #define _DL_PLATFORMS_COUNT 4 > > /* We cannot provide a general printing function. */ > diff --git a/sysdeps/powerpc/dl-procinfo.h b/sysdeps/powerpc/dl-procinfo.h > index b36697ba44..5b628a27ca 100644 > --- a/sysdeps/powerpc/dl-procinfo.h > +++ b/sysdeps/powerpc/dl-procinfo.h > @@ -41,9 +41,6 @@ > #define _DL_PLATFORMS_COUNT 17 > > #define _DL_FIRST_PLATFORM 32 > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (((1ULL << _DL_PLATFORMS_COUNT) - 1) \ > - << _DL_FIRST_PLATFORM) > > /* Platform bits (relative to _DL_FIRST_PLATFORM). */ > #define PPC_PLATFORM_POWER4 0 > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index 63c9889f94..bb5f9c7863 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -27,9 +27,6 @@ extern const char _dl_s390_cap_flags[_DL_HWCAP_COUNT][9] attribute_hidden; > > /* The kernel provides up to 32 capability bits with elf_hwcap. */ > #define _DL_FIRST_PLATFORM 32 > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (((1ULL << _DL_PLATFORMS_COUNT) - 1) \ > - << _DL_FIRST_PLATFORM) > > /* Hardware capability bit numbers are derived directly from the > facility indications as stored by the "store facility list" (STFL) > diff --git a/sysdeps/sparc/dl-procinfo.h b/sysdeps/sparc/dl-procinfo.h > index dbb1a4d324..bd1cb65596 100644 > --- a/sysdeps/sparc/dl-procinfo.h > +++ b/sysdeps/sparc/dl-procinfo.h > @@ -57,7 +57,4 @@ _dl_hwcap_string (int idx) > #define HWCAP_IMPORTANT (HWCAP_IMPORTANT_V9 | HWCAP_SPARC_ULTRA3 \ > | HWCAP_SPARC_BLKINIT | HWCAP_SPARC_N2) > > -/* There're no platforms to filter out. */ > -#define _DL_HWCAP_PLATFORM 0 > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > index 0ed89c5e41..17893a5225 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > @@ -37,7 +37,4 @@ _dl_hwcap_string (int idx) > return (unsigned)idx < _DL_HWCAP_COUNT ? GLRO(dl_aarch64_cap_flags)[idx] : ""; > }; > > -/* There're no platforms to filter out. */ > -#define _DL_HWCAP_PLATFORM 0 > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > index 2a1c5985ee..85422b8edd 100644 > --- a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > @@ -30,9 +30,6 @@ > /* Low 7 bits are allocated in HWCAP2. */ > #define _DL_HWCAP2_LAST 6 > > -/* The kernel provides platform data but it is not interesting. */ > -#define _DL_HWCAP_PLATFORM 0 > - > > static inline const char * > __attribute__ ((unused)) > diff --git a/sysdeps/x86/dl-procinfo.h b/sysdeps/x86/dl-procinfo.h > index b2184b8f5d..1aa6bad67a 100644 > --- a/sysdeps/x86/dl-procinfo.h > +++ b/sysdeps/x86/dl-procinfo.h > @@ -26,8 +26,5 @@ > > /* Start at 48 to reserve spaces for hardware capabilities. */ > #define _DL_FIRST_PLATFORM 48 > -/* Mask to filter out platforms. */ > -#define _DL_HWCAP_PLATFORM (((1ULL << _DL_PLATFORMS_COUNT) - 1) \ > - << _DL_FIRST_PLATFORM) > > #endif /* dl-procinfo.h */