From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29778 invoked by alias); 23 Sep 2016 14:16:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 29767 invoked by uid 89); 23 Sep 2016 14:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-yw0-f179.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nhwVw2tIpXdmhrwIZ0NhstXWWTfJlZBOywnajEMeTRg=; b=JuRBp6Vaq4CBIxlhm15NkN3r1OkGM70VKp+FGZBHb0np1D8C1nO3d8axRm4JT1NWZV UyZZoYw+ibSNu4VN4JHLwP/L82hdcx/aK4yAEspzZmZpPOuPooC5EaRjME8WDIcIUxVs EVrqDDN10hpr+7c2/aA2AsYSM/tIkwaStDGjTuGM9LrLhP1kgbn8iR6SjbYNxexyuiCC VdX42pK+DXrwhot5+x4Y8r4JqOP/gwNS3EfWV620SYx4kDtipqaO/q4pfeFkX7eOx/kq iM01iaq4UCj5sNTmj/Rx8h2ac6DZO9whwqk1D2lq8pYOJ+Hrd3Q81dIqNVY8FuXZdMrC NOww== X-Gm-Message-State: AE9vXwOy9esGhYTZL0Z8PFQ7Ee0wQltyNjsDhnObP0VphZxc62c6rsB/vjKS9NOwqiod5ESe X-Received: by 10.129.103.137 with SMTP id b131mr6559639ywc.217.1474640163033; Fri, 23 Sep 2016 07:16:03 -0700 (PDT) Subject: Re: [PATCH 1/4] Add INTERNAL_SYSCALL_CALL To: Florian Weimer References: <1474383714-15187-1-git-send-email-adhemerval.zanella@linaro.org> <1474383714-15187-2-git-send-email-adhemerval.zanella@linaro.org> <87h99amey7.fsf@mid.deneb.enyo.de> <89560945-9ba0-395a-3829-bb0eae62affb@linaro.org> <87k2e5gir6.fsf@mid.deneb.enyo.de> <87h997znb9.fsf@mid.deneb.enyo.de> Cc: libc-alpha@sourceware.org From: Adhemerval Zanella Message-ID: <65d79118-50d0-8732-38d1-30d2bb013036@linaro.org> Date: Fri, 23 Sep 2016 14:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87h997znb9.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00493.txt.bz2 On 22/09/2016 17:34, Florian Weimer wrote: > * Adhemerval Zanella: > >> We can, at least for x86_64 for instance where it uses another indirection >> for INTERNAL_SYSCALL. However, something similar fails for i386, where >> macro substitution for INTERNAL_SYSCALL will try string concatenation and >> thus mess with intended behaviour. Also, _SYSCALL_NARGS macro would be >> required to be different to take in consideration the 'err' argument >> required for INTERNAL syscall (something I noted I coded wrong). >> >> I think calling the {INLINE,INTERNAL}_SYSCALL directly would be the safer >> and agnostic approach to avoid issues on how they are actually implemented >> by each port. > > Okay, it looks like this is the better way for now. > >> I tested the following patch with a build for practically all current >> supported ports (aarch64, alpha, armeabi, armeaihf, hppa, ia64, i386, m68k, >> microblaze, mips{32,64,n64}, nios2, powerpc{32,64,64le}, s390{-32,-64}, sh4, >> sparc{64}, tile{pro,x64}, x86_64, and x32) and saw no build issues. I also >> checked on x86_64 and i386. To actually check INTERNAL_SYSCALL_CALL macro >> work I changed sysdeps/unix/sysv/linux/pthread_setaffinity.c to use it. > > Did you see object code changes from that? I haven't checked all of the, but at least x86_64, i386, aarch64, and powerpc64le do not change. I presume it is ok to push upstream, correct?