From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31166 invoked by alias); 8 Dec 2016 02:56:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 31132 invoked by uid 89); 8 Dec 2016 02:56:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Others X-HELO: mail.pacific.net Subject: Re: [PATCH v2 3/5] manual: Add new header and standards annotations. To: Joseph Myers References: <20161206105525.21117-1-ricaljasan@pacific.net> <20161206105525.21117-4-ricaljasan@pacific.net> Cc: libc-alpha@sourceware.org, mtk.manpages@gmail.com, carlos@redhat.com From: Rical Jasan Message-ID: <665e49d4-dfa0-e14d-a793-d4acdca8e617@pacific.net> Date: Thu, 08 Dec 2016 02:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Null-Tag: cedbb65caed2393341aca1794993e4a7 X-SW-Source: 2016-12/txt/msg00263.txt.bz2 On 12/07/2016 08:31 AM, Joseph Myers wrote: > On Tue, 6 Dec 2016, Rical Jasan wrote: > >> diff --git a/manual/argp.texi b/manual/argp.texi >> index bca3ca5..f1767cc 100644 >> --- a/manual/argp.texi >> +++ b/manual/argp.texi > > All the changes to this file are OK. > >> diff --git a/manual/arith.texi b/manual/arith.texi >> index 0c182c5..eee9880 100644 >> --- a/manual/arith.texi >> +++ b/manual/arith.texi > > All the changes to this file are OK. Note for when making annotations > more consistent in standard naming in future that: > >> @@ -714,7 +724,11 @@ such as by defining @code{_GNU_SOURCE}, and then you must include >> @comment math.h >> @comment ISO >> @deftypevr Macro float SNANF >> +@comment math.h >> +@comment TS 18661-1:2014 >> @deftypevrx Macro double SNAN >> +@comment math.h >> +@comment TS 18661-1:2014 >> @deftypevrx Macro {long double} SNANL > > All three are TS 18661-1:2014. > >> @@ -2041,8 +2055,10 @@ NaN. >> @comment math.h >> @comment ISO >> @deftypefun int totalorder (double @var{x}, double @var{y}) >> +@comment math.h >> @comment ISO >> @deftypefunx int totalorderf (float @var{x}, float @var{y}) >> +@comment math.h >> @comment ISO >> @deftypefunx int totalorderl (long double @var{x}, long double @var{y}) >> @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}} >> @@ -2063,8 +2079,10 @@ payload. >> @comment math.h >> @comment ISO >> @deftypefun int totalordermag (double @var{x}, double @var{y}) >> +@comment math.h >> @comment ISO >> @deftypefunx int totalordermagf (float @var{x}, float @var{y}) >> +@comment math.h >> @comment ISO >> @deftypefunx int totalordermagl (long double @var{x}, long double @var{y}) > > As are all these. Right. I have a branch with these, and the way I originally designed the patchset those would have gone in v2 5/5 since they would have been changes and not purely new, but they didn't make it. I started to go down a rabbit hole when dealing with ISO because I couldn't address all of them based on immediate context, so I had shelved it for the time being as incomplete (unlike the conversion of X/Open to XOPEN, which was purely formatting, and complete, for example). v2 5/5 wound up focusing on formatting, and reducing the variety of alternate spellings of the same standard, and not converting all the names I could. >> diff --git a/manual/lang.texi b/manual/lang.texi >> index 6281840..5e4d1d3 100644 >> --- a/manual/lang.texi >> +++ b/manual/lang.texi > > All the changes to this file are OK apart from the question of whether to > document __va_copy at all. It'll error out after check-stds.pl is added if it isn't annotated, and we can always remove it later once that question is answered. Others will have to weigh in on the matter, though; I don't have much of an opinion either way. >> diff --git a/manual/string.texi b/manual/string.texi >> index 1986357..683a20f 100644 >> --- a/manual/string.texi >> +++ b/manual/string.texi > > All the changes to this file are OK. > > I think the approved pieces should be committed to reduce the size of the > patch in future revisions. That would be for someone other than myself to handle, correct? Then, when I rebase against master for v3, it'll be automatically adjusted. Should the commit message be changed, for either one or the other? Rical