From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fossa.birch.relay.mailchannels.net (fossa.birch.relay.mailchannels.net [23.83.209.62]) by sourceware.org (Postfix) with ESMTPS id 3C2A8385782C for ; Mon, 21 Dec 2020 07:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C2A8385782C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 54703100E53; Mon, 21 Dec 2020 07:43:16 +0000 (UTC) Received: from pdx1-sub0-mail-a63.g.dreamhost.com (100-105-161-17.trex.outbound.svc.cluster.local [100.105.161.17]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B851C100F6D; Mon, 21 Dec 2020 07:43:15 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a63.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 21 Dec 2020 07:43:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Power-Attack: 3d080853596bae5d_1608536596162_2245320721 X-MC-Loop-Signature: 1608536596162:1252614653 X-MC-Ingress-Time: 1608536596161 Received: from pdx1-sub0-mail-a63.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTP id 549137F0C2; Sun, 20 Dec 2020 23:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=LoJjfj OSS9jqoyB1hEapGDCeMS8=; b=wm7663l72t1SlPyowHthOJ2ExhIkzo8fke2qnc AK/j+1uIxcGO+WDOL42cGzLegVV2RQ0viYVNkcB2yFB1QAFWEV33CnGYam0zA2c6 h2qJ7EuPEN4Ldm+9LV+rCM/VfoOhzo3VD6WFIviPSM/dJIKJyKFbWucOIvk2w9fD rhVC0= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTPSA id DD9117EFFF; Sun, 20 Dec 2020 23:43:12 -0800 (PST) Subject: Re: [PATCH] free: preserve errno [BZ#17924] To: Paul Eggert , Carlos O'Donell Cc: libc-alpha@sourceware.org References: <20201220202556.3714-1-eggert@cs.ucla.edu> X-DH-BACKEND: pdx1-sub0-mail-a63 From: Siddhesh Poyarekar Message-ID: <66e5a890-dbd6-0c32-ff7a-08faa4ed0dce@gotplt.org> Date: Mon, 21 Dec 2020 13:13:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 07:43:20 -0000 On 12/21/20 12:50 PM, Paul Eggert wrote: > From e4fec6f28270c9b0979f9fe8920dc52f8f7d70cd Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Sat, 19 Dec 2020 12:52:09 -0800 > Subject: [PATCH] free: preserve errno [BZ#17924] > > In the next release of POSIX, free must preserve errno > . > Modify __libc_free to save and restore errno, so that > any internal munmap etc. syscalls do not disturb the caller's errno. > Add a test malloc/tst-free-errno.c (almost all by Bruno Haible), > and document that free preserves errno. Thanks, this version looks good to me. Reviewed-by: Siddhesh Poyarekar