From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fennec.ash.relay.mailchannels.net (fennec.ash.relay.mailchannels.net [23.83.222.58]) by sourceware.org (Postfix) with ESMTPS id F1AB23858433 for ; Wed, 22 Mar 2023 18:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1AB23858433 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5D391261308; Wed, 22 Mar 2023 18:52:17 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E125A26158C; Wed, 22 Mar 2023 18:52:16 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1679511136; a=rsa-sha256; cv=none; b=4GSB1e00vbEdpb/lumBpx0vKt679QrMJ3b06Jvzfv5sVNSJcrF67TUouVo7dyI9U9grhgv dJHmSzvNT4I2ovuLDoJTxvoZxI6aLcm0uTyKi4kaes4bta2N47OpYpEeOmbOG1qo4OP5oV FP+iM3eomm1CBv+nY4YGYVttGtnopygcIAFsOixFwTPG6AIT4Ss66pQDpXTptt8ltUFe0/ uxN3eLyp6hc5LEpDVXfGsuRCYkp6Xs0PSCID8/84zg5n8GOphNeFif9SVgN8T4rktNTgE0 AmoImA/YEQ2wCRLrG3WhB8GsskA/ErTBJJWms3q8vPzt/PF/QA5UzHguwmx2tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1679511136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zM44CcC+FpF2SH3GCW5C6XCVjWTHNAav0E83lvgN/C8=; b=ZeMHpw8ccQZR37SsxivM4F76SRUxJuM3LE/oR0lIIaA/w7lMyP7zZXYeUKvH+qsmtlJSZt 5xPP39c6vPQXz41HMqMhXeXf9dKztIgxZyRIu/cFzIrkM+n6C7pLCIYpMhnaY+88OKp5Jp nMzHDoQ4vLAOWYq3yag3LPV8thd4S0Lw7B4D3hLYWByA2C8qAUn8ewaL2FpXM/bsK33w1d K5i++9H27m0i4l95NPUE4INdhxhBdQJfwIT+GumJ7LjJqNIYYWO40+ZuQc4xBoiBzbW9pv fKg5H70rsHACfZ7ziN+ZlHAn2vjULINgcMrR3HZl/MIj2pxSgu5ryC/oWdQLSA== ARC-Authentication-Results: i=1; rspamd-9576589d-g84wj; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Relation-Dime: 57facedc22b1c748_1679511137153_1471118932 X-MC-Loop-Signature: 1679511137152:2714965713 X-MC-Ingress-Time: 1679511137152 Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.114.243.17 (trex/6.7.2); Wed, 22 Mar 2023 18:52:17 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-153.dsl.bell.ca [174.91.45.153]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4Phcz42jMFz84; Wed, 22 Mar 2023 11:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1679511136; bh=zM44CcC+FpF2SH3GCW5C6XCVjWTHNAav0E83lvgN/C8=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=XZc9iseAj1QNr2fymli6BpvHO6SD/ZKYZzbjgNJmZ+QME3F+m/2tGOipZi7QLDzFI i0zE2V+roj7ItfSwKOBIXDAJBw0rLmcYWrAZKf5l+yDk7xy0Lx3GG89q6WFc+nE6Og vS+Ij6tejYXrvDRRo7my+pCxzIgCb++vdzh/C9PdGlrbVo+g1e0Fwx/CbAFi+gEr6S hyYtuS2mL+LV6UNjwk1H0TwFfCvb/iCfWLV6D9qKbdMnLTnaq1gss2mk2PF4NZt0Rp 5D3MSw+EZxUh6H7+QE8IJVvzO2tpsrrF0NFKCufXB/D0wA0LDiTGDxIPcOqq4568Ow 6sKpm1ntdCcFA== Message-ID: <67b70774-d319-b23d-3d42-b08aa5f10da2@gotplt.org> Date: Wed, 22 Mar 2023 14:52:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] elf: Remove glibc.rtld.dynamic_sort tunable Content-Language: en-US To: Adhemerval Zanella Netto , libc-alpha@sourceware.org, Florian Weimer References: <20230313190627.2000578-1-adhemerval.zanella@linaro.org> <20230313190627.2000578-2-adhemerval.zanella@linaro.org> <45835a92-55a1-6637-183a-4ecad79d9065@linaro.org> <50f4d048-bdde-fccc-fdd2-edd7b67994ee@gotplt.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-03-22 14:46, Adhemerval Zanella Netto wrote: >> OK, I'll stick to reviewing the --enable-tunables patch then, assuming that it can go in independently of this one.  I feel much less comfortable acking this one since I haven't been closely involved in sorting algorithm selection.  I get the sense that maybe it makes sense to wait a couple more releases before removing the old sort algorithm but that's not based on any specific knowledge, just an instinct. > > Well, without tunables the old algorithm can not be selected. So the second > part does depend of this. I don't get it, wouldn't the old algorithm get selected using the glibc.rtld.dynamic_sort tunable? How would the ability to disable tunables affect that? > The old algorithm was kept mainly to provide some fallback compatibility to > binaries that does not work correctly with newer one; but the default one > is already in 3 release, it is faster, and so far I have not heard of any > drawnback. It may take 2-3 years for some of the slower moving application devs to get to use the current glibc, hence my spitball about another year or so. But don't mind my opinion on this, hopefully others can chime in on it. Thanks, Sid