From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc: Simplify implementation of __malloc_assert
Date: Thu, 21 Jul 2022 10:40:11 -0300 [thread overview]
Message-ID: <67d80a43-c65a-b9db-af46-c73562e6c5b2@linaro.org> (raw)
In-Reply-To: <87ilnq38cs.fsf@oldenburg.str.redhat.com>
On 21/07/22 10:26, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
>
>>> + __libc_message (do_abort, "\
>>> +Fatal glibc error: malloc assertion failure in %s: %s\n",
>>> + function, assertion);
>>> + __builtin_unreachable ();
>>> }
>>> #endif
>>> #endif
>>>
>>
>> Would be better to keep the the file and line information?
>
> I would have to figure out how to use _itoa correctly. 8-/
Yeah, it is not the best interface indeed.
>
> I think we converted almost all asserts that are reachable through heap
> corruption into malloc_printerr a couple of years ago, so the diagnostic
> value of the line number will be really low. That's why I had to resort
> to GDB to test this.
>
> Do you insist that I add file and line number information?
I think it should be ok, what bothers me is we need to reimplement the
assert macro for malloc usage.
next prev parent reply other threads:[~2022-07-21 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:34 Florian Weimer
2022-07-21 11:43 ` Siddhesh Poyarekar
2022-07-21 12:36 ` Carlos O'Donell
2022-07-21 13:10 ` Adhemerval Zanella Netto
2022-07-21 13:24 ` Adhemerval Zanella Netto
2022-07-21 13:28 ` Florian Weimer
2022-07-21 13:26 ` Florian Weimer
2022-07-21 13:40 ` Adhemerval Zanella Netto [this message]
2022-07-22 11:38 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d80a43-c65a-b9db-af46-c73562e6c5b2@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).