From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 795833858C27 for ; Fri, 26 Mar 2021 19:32:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 795833858C27 Received: by mail-qk1-x72e.google.com with SMTP id 7so6387537qka.7 for ; Fri, 26 Mar 2021 12:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GsnYpyCRlF3VSr79Nynl5+n2xinLnRiiXh4xjDRUMCM=; b=fuKQuoFeQmc1cFAlFEC9OTlcVKQ8TFZi2vzlrk3RFjj2yQLQggvho7Be24sqMakrVh tmw7+1ccmoPKYAoPo2KiDGqbjCIQGkWHUioCr5LA4sUAZRlllBbLHARK2Ic0EnJmE6Bl brE/gqckkr84pLgh9/1T7J01a7M1NczETaRmktgove6TEtpK/TvIroDEYPlTDpOfzOnq tF8dvxlPi0iIQPajoX4gpdcUAoBa3+xpNYRby6qen5NBTR2bcB5m3885OScMT63poiZe XtrRkM21azJa/OhCN/J6QJX8N4U7s4seXONmTskNUU87MvqlUKQdx+FbZO+SUhW4bd9g cdRA== X-Gm-Message-State: AOAM532e+mpZcQ1dgzqzjpj0NM+f09qAokURSZytJ8HW2QJ9bJzifcoS ydk/2peWMJHdTKH2EVmnMXFp3c+BbZH7a1Cc X-Google-Smtp-Source: ABdhPJxOw7pqW2epNsd5bL3ccjV0GYugxYgmYea8PSSf9iHZO0oLCsfk/uvigZbsuI7ClftIfCweRA== X-Received: by 2002:a37:b81:: with SMTP id 123mr14833627qkl.466.1616787151737; Fri, 26 Mar 2021 12:32:31 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id q24sm7202392qki.120.2021.03.26.12.32.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 12:32:31 -0700 (PDT) Subject: Re: [PATCH 1/5] linux: Implement fstatat with __fstatat64_time64 To: libc-alpha@sourceware.org References: <20210319183121.2252064-1-adhemerval.zanella@linaro.org> <20210319183121.2252064-2-adhemerval.zanella@linaro.org> <5970116c-2af3-2f02-d526-e89008d36f18@linux.ibm.com> From: Adhemerval Zanella Message-ID: <67dbc2fc-c1e0-e05c-39d4-dab4ad661e22@linaro.org> Date: Fri, 26 Mar 2021 16:32:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <5970116c-2af3-2f02-d526-e89008d36f18@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2021 19:32:35 -0000 On 26/03/2021 06:24, Stefan Liebler via Libc-alpha wrote: > On 19/03/2021 19:31, Adhemerval Zanella via Libc-alpha wrote: >> It makes fstatat use __NR_statx, which fix the s390 issue with >> missing nanoxsecond support on compat stat syscalls (at least >> on recent kernels) and limits the statx call to only one function >> (which simplifies the __ASSUME_STATX support). >> >> Checked on i686-linux-gnu and on powerpc-linux-gnu. >> --- >> sysdeps/unix/sysv/linux/fstatat.c | 52 +++++++------------------------ >> 1 file changed, 11 insertions(+), 41 deletions(-) >> >> diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c >> index 59efff615f..618c254d6f 100644 >> --- a/sysdeps/unix/sysv/linux/fstatat.c >> +++ b/sysdeps/unix/sysv/linux/fstatat.c >> @@ -26,33 +26,19 @@ >> int >> __fstatat (int fd, const char *file, struct stat *buf, int flag) >> { >> - int r; >> - >> -# if STAT_IS_KERNEL_STAT >> - /* New kABIs which uses generic pre 64-bit time Linux ABI, e.g. >> - csky, nios2 */ >> - r = INTERNAL_SYSCALL_CALL (fstatat64, fd, file, buf, flag); >> - if (r == 0 && (buf->__st_ino_pad != 0 >> - || buf->__st_size_pad != 0 >> - || buf->__st_blocks_pad != 0)) >> - return INLINE_SYSCALL_ERROR_RETURN_VALUE (EOVERFLOW); >> -# else >> -# ifdef __NR_fstatat64 >> - /* Old KABIs with old non-LFS support, e.g. arm, i386, hppa, m68k, mips32, >> - microblaze, s390, sh, powerpc, and sparc. */ >> - struct stat64 st64; >> - r = INTERNAL_SYSCALL_CALL (fstatat64, fd, file, &st64, flag); >> + struct __stat64_t64 st64; >> + int r = __fstatat64_time64 (fd, file, &st64, flag); >> if (r == 0) >> { >> if (! in_ino_t_range (st64.st_ino) >> || ! in_off_t_range (st64.st_size) >> - || ! in_blkcnt_t_range (st64.st_blocks)) >> + || ! in_blkcnt_t_range (st64.st_blocks) >> + || ! in_time_t_range (st64.st_atim.tv_sec) >> + || ! in_time_t_range (st64.st_mtim.tv_sec) >> + || ! in_time_t_range (st64.st_ctim.tv_sec)) >> return INLINE_SYSCALL_ERROR_RETURN_VALUE (EOVERFLOW); > OK >> >> - /* Clear internal pad and reserved fields. */ >> - memset (buf, 0, sizeof (*buf)); > Do we have to clear the user provided struct as before? I think it is not strictly required, but some architecture does have padding and reserved fields. I will reinstate it, the compiler should have enough information to only zero the fields not actively set.