From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87054 invoked by alias); 10 Nov 2016 12:15:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86861 invoked by uid 89); 10 Nov 2016 12:15:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=consolidates, __nr_, nonlinux, nonLinux X-HELO: mail-ua0-f177.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=iSQBCZrs/0Tv2tT6X4G8YWI/JZHSMp8Q2iLQ1nCHlqQ=; b=HGOaQKgMPqAiY1RBdrMZdV4RlcbptpWHJcraYaPNeMD34gPI0CCpxc3NvKHdUob5Eg gfaSs2hpl4GOOh8i2uaiped66YK/synHXEJeOSzP7N6FPKXhEopvku2zgrEnMl36Ouqt mdLaunHGUcMfKi3UEdeJXCwAAWXuaU9WAJFaytZwpBKdvxNH+VfuIO5BC9DCEGY5f+HB jjUYN9cSVbCBnNmAXnAFn7VPu0bhJ6hn9YrA1VcraDfla5q2IjcaCwyY/CxXuajcESYc E50L+ErOnE5GauCA/ZIKiQdyaK59SbbfNgGdQJuZme2Ec/W8J9xmhiFnhHtRsdIOST66 K0rw== X-Gm-Message-State: ABUngvdokLL3MBwf6h/QKnoe7K0uO24HPZvXSmBTbbgmv2r0Ps+WuVi2YiwIM3o/ZUeJ6Uhh X-Received: by 10.176.7.8 with SMTP id h8mr2590291uah.114.1478780094579; Thu, 10 Nov 2016 04:14:54 -0800 (PST) Subject: Re: [PATCH 2/6] New internal function __access_noerrno To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <1477320168-23397-1-git-send-email-siddhesh@sourceware.org> <1477320168-23397-3-git-send-email-siddhesh@sourceware.org> <317e63c8-1681-84b1-e278-c6ecae71e657@linaro.org> <4f13d235-084b-25f8-b763-053889b0dfdb@gotplt.org> <9fee5a6f-bde3-6f5f-d8ee-5ab6c8771873@gotplt.org> From: Adhemerval Zanella Message-ID: <67e3afd8-d1ea-ef52-dcf4-c8c4372a3410@linaro.org> Date: Thu, 10 Nov 2016 12:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9fee5a6f-bde3-6f5f-d8ee-5ab6c8771873@gotplt.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-11/txt/msg00391.txt.bz2 On 10/11/2016 03:44, Siddhesh Poyarekar wrote: > On Wednesday 09 November 2016 12:30 AM, Siddhesh Poyarekar wrote: >> I can hack at sysdeps/unix/sysv/linux/access.c and drop >> sysdeps/unix/access_noerrno.c. > > Turns out I can't do this because I will be breaking non-Linux > configurations that use the SYS_ prefix instead of the __NR_ prefix. I > also discovered that I hadn't actually tested the code properly on > aarch64 and it is broken, so I'll resend the patchset. > > Siddhesh In this branch [1] I have a WIP for this. First patch basically consolidates access Linux implementation and it uses the strategy to check for __NR_access first (and since it on sysdeps/.../linux it should not worry about __SYS_*). Second one is the __access_errno implementation. It basically handles the 3 cases (hurd, nacl, and Linux) by adding the __access_errno on access.c. I think it should a cleaner solution to __access_noerro (less macro handling and build objects). [1] https://github.com/zatrazz/glibc/commits/master-access_noerrno