From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id A35CF3854147 for ; Fri, 30 Sep 2022 13:55:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A35CF3854147 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1664546118; bh=9kcNG82XYWeYk8/fmuDoZxVyjlDCXMmRsp8orDJaRn4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=bFM7kV4wZfrfS9m7tObAuNijuA4Q2ZDgolWvt1qD/625vvm39PsshsxE/8IGC1IEQ O8xpwJ5BbIVuiXaxnEzKGjLXRgYQ4rGT8NEM7UcBWElPuM5lvoxoxMlmkh2Xlv8Tpw pzrQL7jYO0hXWhphOkY6eQKbOEazIzp7152GRnwQ= Received: from [IPv6:240e:358:1175:c700:dc73:854d:832e:3] (unknown [IPv6:240e:358:1175:c700:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 5525B66772; Fri, 30 Sep 2022 09:55:12 -0400 (EDT) Message-ID: <6807d80d06d2035e3b5353510f7dde50db743ab2.camel@xry111.site> Subject: Re: [PATCH v3 1/1] LoongArch: Add static PIE support From: Xi Ruoyao To: Adhemerval Zanella Netto , caiyinyu , libc-alpha@sourceware.org Cc: Chenghua Xu , Lulu Cheng , Wang Xuerui , liuzhensong Date: Fri, 30 Sep 2022 21:55:03 +0800 In-Reply-To: <4538abfd-ec05-bab5-1759-e3b12c6f1eed@linaro.org> References: <20220924074534.1566173-1-xry111@xry111.site> <20220924074534.1566173-2-xry111@xry111.site> <3848ed3c5915a2363ffa8bdd43f74152da125885.camel@xry111.site> <4538abfd-ec05-bab5-1759-e3b12c6f1eed@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_PDS_OTHER_BAD_TLD autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2022-09-30 at 09:54 -0300, Adhemerval Zanella Netto wrote: >=20 >=20 > On 30/09/22 09:47, Xi Ruoyao via Libc-alpha wrote: > > On Thu, 2022-09-29 at 21:32 +0800, caiyinyu wrote: > > > Here are some mistakes: > >=20 > > Sorry for the stupid mistake...` > >=20 > > I need to be AFK for several days, will send v4 once I'm back. > >=20 > > > diff --git a/sysdeps/loongarch/configure > > > b/sysdeps/loongarch/configure > > > index 70d6fec5c1..6edd6d08a5 100644 > > > --- a/sysdeps/loongarch/configure > > > +++ b/sysdeps/loongarch/configure > > > @@ -14,10 +14,10 @@ else > > > =C2=A0=C2=A0.global _start > > > =C2=A0=C2=A0.type _start, @function > > > =C2=A0=C2=A0_start: > > > -=C2=A0 li.w $a7, 93 > > > +=C2=A0 li.w \$a7, 93 > > > =C2=A0=C2=A0=C2=A0 /* This ensures the assembler supports explicit re= loc.=C2=A0 */ > > > -=C2=A0 pcalau12i $a0, %pc_hi20(x) > > > -=C2=A0 ld.w $a0, $a0, %pc_lo12(x) > > > +=C2=A0 pcalau12i \$a0, %pc_hi20(x) > > > +=C2=A0 ld.w \$a0, \$a0, %pc_lo12(x) > > > =C2=A0=C2=A0=C2=A0 syscall 0 > >=20 >=20 >=20 > I was committed upstream nevertheless=C2=A0 > (8b10727a9af3e2aa4b27dff0116bb8d3c9afce3d). > It upstream correct or does it require a the above fix? Upstream is correct. Thanks! --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University