From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.22]) by sourceware.org (Postfix) with ESMTPS id AFFAF3881811 for ; Tue, 9 Apr 2024 22:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFFAF3881811 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=clisp.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=clisp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFFAF3881811 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=85.215.255.22 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712701251; cv=pass; b=IJOL2/XokNdx9ty12bdw+5SgR9hHrHhrUyyoes9b7mdS6zQmkPYHvgTiCUtSU9NTDXH6vnx8uSrqHO+JdfeRIC/KFLUcX/Yb7cyoEPGPugDogIpXhQUXETRqn0JGGZwuhstdLNVirwEPE1a7Wd95+OgqTzOsLzsIRDzy6nEAp9I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712701251; c=relaxed/simple; bh=smZQm+HhFkK76ThZ6K15voGXqJcMOs1oYEh7z7CXbCY=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=u4v3fQlofkOO6RLWKAOqmyAnVoF2hZ2HD78qwtYgDaf+i3/go1Ru28WTpDl/BTy1jPdHvqQjfTOgbUP9ChdKMdhCCxU1VsStKK8RvcO3QTSR9T5j4FY+tdZmvfuLjBGQDnL42DbjownT4qyyM0xq2rJnj3UkbTx63dFCOL8y9DI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1712701237; cv=none; d=strato.com; s=strato-dkim-0002; b=DYSY3xKs9o90Z9bNTvyYKMzqXSMEFl5B2gsSfUdpK3UHzqnUV/TnhcWqIAiBvV+xg9 DjLmexONZ9oe+htg49ChLgSnSR/WWXiej93RbL3FpEDWTXLzC7GCswwjG/674qpRiiLj kYRJze6839E35Dw/TFzy93vGPQukVAMlWyx24HPH//88wdAYbbfqQvR9P9RWCxo37e3u iZSGkrb4W0fHefFTAfh2yu9/AFfKRPY52brH4XTKn549/AGQJKGF3JzUQd2ynZgEfwX5 iIM3WLnz1kcUh3SlMCUIM+8WKLF/NJDIqd3lSEmyjOW23UIo4+5JE5zhkKQBu03qUl+k MjoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1712701237; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=CizypOiu5gX63JYzl618g4rahRVR11I0UQPqw3Zj9Tg=; b=NNhQY48bhk1Jd1j/gBXomTNiaxDdRFkJ8JERClRGyw3TYo6P3Bvl/FFdJyhr5wlmcG sjvl/2yhcTnJfrAJ5/oW4KhJPl9b6uGMkY6Isxo7FNsdkyPLmdvOHsNmo+a7JN1kebDw GkE2wR9ASUsY50NXjHhhyG/g+36zql1f+8pso3GVx4GHHVl9Ha3us8l2XFPIxZTHOO84 WOzklGypKNelVzZZxa2EnjLCYGweaDtlpZx9SSY0ZgCYR9DqF/wQWSqTf4fB5hPpUGpY E8G4VrJzn43wqImAlRovHc4BaVJj62TFlRPYT5rPsXUBhr0HKxh4yJOTyDY2SHV4/j5F OS/A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1712701237; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=CizypOiu5gX63JYzl618g4rahRVR11I0UQPqw3Zj9Tg=; b=gzJxVXda5RDbL9U350321tEtjVxAw+mVeJhoBuNzDUjGd07lND76nPjycq1ywbkltw w8zRPolypnK5o/c7G72UIsGDcEXx0cuhV7wF0sMpld1U3m58zVNPX/l5nVTNqjn520qf dQQBe/Rx2/pc2OKfK7X60Yt6N7PfveZu14MIz8CsYOpX9ryEPN0UtJFxfei64nOVQDqL 591qJR01ytmbVd5E/fy3454Qny+C5BKmWu3iHkaP/+YkkvB6bSNUXMsWXZBUAaFaF0Ii DTbibxZOJYf66HQWyaoiyTV1IerA/guG8FRqX6Fxp0roQNvAKz9t4dlC8oB8nWemwuHg gkTw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1712701237; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=CizypOiu5gX63JYzl618g4rahRVR11I0UQPqw3Zj9Tg=; b=ZSSd/6sfy5L4xg6HnZV2Yxxu4eBTPtqu3wseBi7oDvlUPrpMT3UlHS8q/J2t1GtGRT DxEGGQu5jjtXo9X/VBAQ== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOeivSCM4AAweSmhSFDEtspRF0gAg==" Received: from nimes.localnet by smtp.strato.de (RZmta 50.3.2 AUTH) with ESMTPSA id N86100039MKbNPq (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 10 Apr 2024 00:20:37 +0200 (CEST) From: Bruno Haible To: libc-alpha@sourceware.org, Adhemerval Zanella Cc: Paul Eggert Subject: Re: [PATCH v4] posix: Sync tempname with gnulib Date: Wed, 10 Apr 2024 00:20:37 +0200 Message-ID: <6820097.n1QcUsQ7Il@nimes> In-Reply-To: <20240408184954.2518702-1-adhemerval.zanella@linaro.org> References: <20240408184954.2518702-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval, Just a few comments, concentrating on the differences between gnulib and glibc. > The 044bf893ac removed __path_search, which is now moved to another > gnulib shared files (stdio-common/tmpdir.{c,h}) and this patch > also fixes direxists to use __stat64_time64 instead of __xstat64. Thanks; I now see that I had suggested this in . 1) In gnulib, tmpdir.h and tmpdir.c are under LGPLv3+. For glibc, the license header needs to be changed to LGPLv2+. That is s/version 3/version 2.1/ But before doing this, you need to get permission to do it. Since the copyright header says "(C) FSF", you need to ask the FSF's copyright clerk for this permission. Last I tried, this process is very VERY *VERY* slow. Alternatively, you can ask the contributors of significant changes for their permission. - For tmpdir.h, on its way gettext/lib/tmpdir.h -> gettext/gettext-tools/lib/tmpdir.h -> gnulib/lib/tmpdir.h that's only me. (I checked the git history.) - For tmpdir.c, on its way glibc/sysdeps/posix/tempname.c -> gettext/lib/tmpdir.c -> gettext/gettext-tools/lib/tmpdir.c -> gnulib/lib/tmpdir.c that's only me (2011-08-23) and Paul Eggert (2013-07-15). (I checked the git history.) I hereby give the permission to relax the license of tmpdir.[hc] to LGPLv2+. Paul, do you do the same? 2) In tmpdir.c: Please conditionalize the #include "pathmax.h" with #ifndef _LIBC not #if defined _WIN32 && ! defined __CYGWIN__ so that this change can be merged back to gnulib. 3) In sysdeps/posix/tempname.c: +#if !_LIBC *r = mix_random_values (v, clock ()); +#endif How about adding a comment here? /* In glibc, clock_gettime is expected to always succeed. */ +#if !_LIBC *r = mix_random_values (v, clock ()); +#endif Bruno