From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 04BD1385C6C2 for ; Tue, 11 Jun 2024 20:07:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04BD1385C6C2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 04BD1385C6C2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718136434; cv=none; b=wA/aDu7WzBjp067j+XTjKyocN78+WvJFpqZP2nVW1z24fnCoJYJgiqQokzeeJr3stNJu+oixFX9mo6J6s4wjTaGvu80Z/twH5bW75c1CuWsRiiLhUcAGecKsryAmw2CbyFCTJurf+/ez9teE0JrI0ca5ktCv7bxUGocoimfPdrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718136434; c=relaxed/simple; bh=fFgdL4PUqz+4aNnmPDCNM3P5WRWZzXcuRoQQExM/V5I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UOIcelAatitAAK5qMg1p8l/jaIZKECBfgAPEl/ObEj/mBS/QkeEzWkbpcSGsbKIsHSHDXmhaDEy+2oFfaeiU8f1e5j0Mquy/wfg35t4p8CGywAZdO7DWR3zDGeQxSr+/s08cXG9PF3NjqqCppJi79GB5biinTG5oonfFPKTjlvE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-70436ac872aso1485631b3a.1 for ; Tue, 11 Jun 2024 13:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718136431; x=1718741231; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xcKGtr2KNUIV+KoS/UxPSNx3yNMLxmPwZy/0Qcccj2Q=; b=njlsSGDPb6iwdndCczoQ+ea12Tj2rx5sXdp/01kfaAMTd5DjC+5lcBiyhCT3dZjR7S 9r+YV7WW57EVkprBqTGU4/P9RrYhUnreKaVWRUk1VoTJDfgehZK1BKOZSHSXxHgdRYHh rHj7kBv6WM+whKvM/yIbAzQ+5msq8bcIljm2lV0kkT5ibn47k28HEYJ1tP6DIQP2qNzS uOpMVk8PhALKMtuc2xyPg6ZDMg+xYrs36nVmtXabIP4yc4AKQmF6eWqDEImspK8z3cBb uqk3NhvZQNbLtGcRVE9BF51zjlvZ33EHkXaQh+ZvkIJ1FJBo/7DkwyVEkEmgP7uOJfzh Ch9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718136431; x=1718741231; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xcKGtr2KNUIV+KoS/UxPSNx3yNMLxmPwZy/0Qcccj2Q=; b=XTFWK2qQZGP6zJHr7+X7ZDQf4bPp8IHDlIMc5zXiXAnkpTlDiHlAoPydhXFnscI8gh yoMym0IGj5OEKpkLv0crQsNbOoW3Oki2uW7zk3IeWK35zF/+jgl/JoBbv47HI5dMRwwU JAKBOyAaj3MXFMRf9VXqJMxLuhEnBqZzPWaTAV0JGv8O2S7iyLAmKh9Tkz94pVsLD7OD lVeyPTvsMyfawnaF2czRnkyEljv9imJ419t8aAOPeYpOSHmUXUb8SktJFbLdNzIcvS/1 NrL/rmWKUbSaO9I1M4O1iClNMlNn0xV9oy3SA9mgW7lTMiJAt9Hpdk1UFaogRWcMHSRx ZXkA== X-Forwarded-Encrypted: i=1; AJvYcCVbQrNw1/Nm6ZKw7S23JIxKz/2bRDoseGkbggUVq4KmmZDFyLcnoG5HCQvdTXfZucckVkoUyeMq5NRcRh3/Y2a4niAIqgZ6Z7Q6 X-Gm-Message-State: AOJu0Yx3XA/ZeYuDvvnMAU1zmPxzzSzt9yR4NPtKMrVnP22z/0Kk9548 rFzoXvta/oYjKLVG1TqLCon5ncLaQcffHiupL6UCpnxPtINlAhIdbcP9pBTjXnE= X-Google-Smtp-Source: AGHT+IEeEDUF5nnDiRfWzSK1aBidgDPPXRudP6A4P7IwcvHepAEwDQ4/dA5scHZV7NOAjZMESv53zA== X-Received: by 2002:a05:6a00:148b:b0:704:2d27:c9b4 with SMTP id d2e1a72fcca58-7042d27cca3mr12312780b3a.14.1718136430884; Tue, 11 Jun 2024 13:07:10 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c5fb:e1da:f9b7:66da:199? ([2804:1b3:a7c0:c5fb:e1da:f9b7:66da:199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-704228c2c74sm6340078b3a.209.2024.06.11.13.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 13:07:10 -0700 (PDT) Message-ID: <6827e5b7-1499-489c-bd1d-22807f5b12fd@linaro.org> Date: Tue, 11 Jun 2024 17:07:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 9/9] elf: Remove HWCAP_IMPORTANT To: Stefan Liebler , libc-alpha@sourceware.org Cc: fweimer@redhat.com, devel@otheo.eu, bergner@linux.ibm.com References: <20240607114543.659306-1-stli@linux.ibm.com> <20240607114543.659306-10-stli@linux.ibm.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240607114543.659306-10-stli@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/06/24 08:42, Stefan Liebler wrote: > Remove the definitions of HWCAP_IMPORTANT after removal of > LD_HWCAP_MASK / tunable glibc.cpu.hwcap_mask. There HWCAP_IMPORTANT > was used as default value. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/dl-diagnostics.c | 1 - > sysdeps/alpha/dl-procinfo.h | 3 --- > sysdeps/csky/dl-procinfo.h | 3 --- > sysdeps/generic/dl-procinfo.h | 3 --- > sysdeps/mips/dl-procinfo.h | 3 --- > sysdeps/powerpc/dl-procinfo.h | 3 --- > sysdeps/s390/dl-procinfo.h | 5 ----- > sysdeps/sparc/dl-procinfo.h | 5 ----- > sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h | 3 --- > sysdeps/unix/sysv/linux/arm/dl-procinfo.h | 2 -- > sysdeps/x86/dl-hwcap.h | 13 ------------- > 11 files changed, 44 deletions(-) > > diff --git a/elf/dl-diagnostics.c b/elf/dl-diagnostics.c > index e69463b2bd..c83e7770d8 100644 > --- a/elf/dl-diagnostics.c > +++ b/elf/dl-diagnostics.c > @@ -233,7 +233,6 @@ _dl_print_diagnostics (char **environ) > { > _dl_diagnostics_print_labeled_string ("dl_dst_lib", DL_DST_LIB); > _dl_diagnostics_print_labeled_value ("dl_hwcap", GLRO (dl_hwcap)); > - _dl_diagnostics_print_labeled_value ("dl_hwcap_important", HWCAP_IMPORTANT); > _dl_diagnostics_print_labeled_value ("dl_hwcap2", GLRO (dl_hwcap2)); > _dl_diagnostics_print_labeled_value ("dl_hwcap3", GLRO (dl_hwcap3)); > _dl_diagnostics_print_labeled_value ("dl_hwcap4", GLRO (dl_hwcap4)); > diff --git a/sysdeps/alpha/dl-procinfo.h b/sysdeps/alpha/dl-procinfo.h > index a5264f9f2c..8d17d42ce2 100644 > --- a/sysdeps/alpha/dl-procinfo.h > +++ b/sysdeps/alpha/dl-procinfo.h > @@ -27,9 +27,6 @@ > /* There are no hardware capabilities defined. */ > #define _dl_hwcap_string(idx) "" > > -/* By default there is no important hardware capability. */ > -#define HWCAP_IMPORTANT (0) > - > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > diff --git a/sysdeps/csky/dl-procinfo.h b/sysdeps/csky/dl-procinfo.h > index 3e7c63ee67..f5f6343cf6 100644 > --- a/sysdeps/csky/dl-procinfo.h > +++ b/sysdeps/csky/dl-procinfo.h > @@ -28,9 +28,6 @@ > /* There are no hardware capabilities defined. */ > #define _dl_hwcap_string(idx) "" > > -/* By default there is no important hardware capability. */ > -#define HWCAP_IMPORTANT (0) > - > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > diff --git a/sysdeps/generic/dl-procinfo.h b/sysdeps/generic/dl-procinfo.h > index 1778fd1057..93edfc00cb 100644 > --- a/sysdeps/generic/dl-procinfo.h > +++ b/sysdeps/generic/dl-procinfo.h > @@ -25,9 +25,6 @@ > /* There are no hardware capabilities defined. */ > #define _dl_hwcap_string(idx) "" > > -/* By default there is no important hardware capability. */ > -#define HWCAP_IMPORTANT (0) > - > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > diff --git a/sysdeps/mips/dl-procinfo.h b/sysdeps/mips/dl-procinfo.h > index 79c2acc388..af2616e1db 100644 > --- a/sysdeps/mips/dl-procinfo.h > +++ b/sysdeps/mips/dl-procinfo.h > @@ -27,9 +27,6 @@ > /* There are no hardware capabilities defined. */ > #define _dl_hwcap_string(idx) "" > > -/* By default there is no important hardware capability. */ > -#define HWCAP_IMPORTANT (0) > - > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > diff --git a/sysdeps/powerpc/dl-procinfo.h b/sysdeps/powerpc/dl-procinfo.h > index 81eb9fba87..1e746a7ab4 100644 > --- a/sysdeps/powerpc/dl-procinfo.h > +++ b/sysdeps/powerpc/dl-procinfo.h > @@ -34,9 +34,6 @@ > /* AT_HWCAP4 feature strings follow the AT_HWCAP3 feature strings. */ > #define _DL_HWCAP4_OFFSET (_DL_HWCAP3_OFFSET + _DL_HWCAP_SIZE) > > -/* These bits influence library search. */ > -#define HWCAP_IMPORTANT (PPC_FEATURE_HAS_ALTIVEC \ > - + PPC_FEATURE_HAS_DFP) > > #define _DL_FIRST_PLATFORM 32 > > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index 7092ed1e2d..45dd11c189 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -59,11 +59,6 @@ enum > HWCAP_S390_SIE = 1 << 22, > }; > > -#define HWCAP_IMPORTANT (HWCAP_S390_ZARCH | HWCAP_S390_LDISP \ > - | HWCAP_S390_EIMM | HWCAP_S390_DFP \ > - | HWCAP_S390_VX | HWCAP_S390_VXE \ > - | HWCAP_S390_VXRS_EXT2) > - > /* We cannot provide a general printing function. */ > #define _dl_procinfo(type, word) -1 > > diff --git a/sysdeps/sparc/dl-procinfo.h b/sysdeps/sparc/dl-procinfo.h > index bd1cb65596..709178706c 100644 > --- a/sysdeps/sparc/dl-procinfo.h > +++ b/sysdeps/sparc/dl-procinfo.h > @@ -52,9 +52,4 @@ _dl_hwcap_string (int idx) > return GLRO(dl_sparc_cap_flags)[idx]; > }; > > -#include > -#define HWCAP_IMPORTANT_V9 (__WORDSIZE == 64 ? 0 : HWCAP_SPARC_V9) > -#define HWCAP_IMPORTANT (HWCAP_IMPORTANT_V9 | HWCAP_SPARC_ULTRA3 \ > - | HWCAP_SPARC_BLKINIT | HWCAP_SPARC_N2) > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > index 17893a5225..b85d4ad8a3 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > @@ -27,9 +27,6 @@ > /* We cannot provide a general printing function. */ > #define _dl_procinfo(type, word) -1 > > -/* No additional library search paths. */ > -#define HWCAP_IMPORTANT HWCAP_ATOMICS > - > static inline const char * > __attribute__ ((unused)) > _dl_hwcap_string (int idx) > diff --git a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > index 85422b8edd..7d26216718 100644 > --- a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > @@ -70,6 +70,4 @@ _dl_procinfo (unsigned int type, unsigned long int word) > return 0; > } > > -#define HWCAP_IMPORTANT (HWCAP_ARM_VFP | HWCAP_ARM_NEON) > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/x86/dl-hwcap.h b/sysdeps/x86/dl-hwcap.h > index 246fdcd831..325f1c467c 100644 > --- a/sysdeps/x86/dl-hwcap.h > +++ b/sysdeps/x86/dl-hwcap.h > @@ -18,19 +18,6 @@ > #ifndef _DL_HWCAP_H > #define _DL_HWCAP_H > > -#if IS_IN (ldconfig) > -/* Since ldconfig processes both i386 and x86-64 libraries, it needs > - to cover all hardware capabilities. */ > -# define HWCAP_IMPORTANT \ > - (HWCAP_X86_SSE2 | HWCAP_X86_64 | HWCAP_X86_AVX512_1) > -#elif defined __x86_64__ > -/* For 64 bit, only cover x86-64 capabilities. */ > -# define HWCAP_IMPORTANT (HWCAP_X86_64 | HWCAP_X86_AVX512_1) > -#else > -/* For 32 bit, only cover i586, i686 and SSE2. */ > -# define HWCAP_IMPORTANT (HWCAP_X86_SSE2) > -#endif > - > enum > { > HWCAP_X86_SSE2 = 1 << 0,