From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by sourceware.org (Postfix) with ESMTPS id 5B9D13858282 for ; Thu, 7 Dec 2023 13:14:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B9D13858282 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ispras.ru ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B9D13858282 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701954898; cv=none; b=TAPmqjkvNJsMfjmMo0JJ7Vui47ktBCtFIQRZ7K07hAB8Dw9mwAMGfI8/gg5buwf5Ebzsh945EsFtn7RM2Pu6JS56DpM5p2p9PWCbu6vl7QJzszHd4n2kBSqPY8OvjuVO5VBQiM0BI33+oTYLfRvtO+uwHPqm+duOf03q+LVMM+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701954898; c=relaxed/simple; bh=VUeDZ5LiZGq1jUw3XIwIef25Ien0KD8tERL7RPniUZI=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=KS6s8HwKB/H0uvbjT0f8ledgX8eCBNt1yxjYclBn/TRlG8UbB0fvUzrra90PuZnTJ3BhizLrRQHKyVHox533Ntak84ZgzhNpnLYTU/XvrXY5nzf91CrTrB8lz2MMT0MXszSabo6qnGnp1chvhDjNNmZI52J+N5wgr2unZ7u8s4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.10.3.121] (unknown [10.10.3.121]) by mail.ispras.ru (Postfix) with ESMTPS id 7E7A740737C6; Thu, 7 Dec 2023 13:14:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 7E7A740737C6 Date: Thu, 7 Dec 2023 16:14:53 +0300 (MSK) From: Alexander Monakov To: Adhemerval Zanella cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/5] Assume only FLAG_ELF_LIBC6 suport In-Reply-To: <20220802145905.2789733-3-adhemerval.zanella@linaro.org> Message-ID: <68a626c2-736a-05e7-17c3-e474dfada728@ispras.ru> References: <20220802145905.2789733-1-adhemerval.zanella@linaro.org> <20220802145905.2789733-3-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2 Aug 2022, Adhemerval Zanella via Libc-alpha wrote: > From: "Lucas A. M. Magalhaes" > > The older libc versions are obsolete for over twenty years now. > This patch removes the special flags for libc5 and libc4 and assumes > that all libraries cached are libc6 compatible and use FLAG_ELF_LIBC6. > > Checked with a build for all affected architectures. > > Co-authored-by: Adhemerval Zanella > Reviewed-by: Adhemerval Zanella > --- a/elf/readelflib.c > +++ b/elf/readelflib.c > @@ -110,16 +108,6 @@ process_elf_file (const char *file_name, const char *lib, int *flag, > program_interpreter = (char *) (file_contents + segment->p_offset); > check_ptr (program_interpreter); > > - /* Check if this is enough to classify the binary. */ > - for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]); > - ++j) > - if (strcmp (program_interpreter, interpreters[j].soname) == 0) > - { > - *flag = interpreters[j].flag; > - break; > - } > - break; > - > case PT_GNU_PROPERTY: > /* The NT_GNU_PROPERTY_TYPE_0 note must be aligned to 4 bytes > in 32-bit objects and to 8 bytes in 64-bit objects. Skip This hunk removes a 'break', resulting in a nonsensical fall-through from 'case PT_INTERP' to 'case PT_GNU_PROPERTY'. Alexander