From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 4/7] login: Add 64-bit time support to utmp/utmpx
Date: Wed, 5 Aug 2020 17:54:17 -0300 [thread overview]
Message-ID: <69053e9f-6961-2672-088b-26f391b1a714@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2008052039310.1829@digraph.polyomino.org.uk>
On 05/08/2020 17:43, Joseph Myers wrote:
> On Wed, 5 Aug 2020, Adhemerval Zanella via Libc-alpha wrote:
>
>> I thought keeping the same filename for architectures that already
>> have 64-bit ut_tv member. However, currently only s390 fits in this
>> category and it would make it an outlier. It means that glibc on s390
>
> But it's not just s390. aarch64, alpha, arc, ia64 all look like they use
> 64-bit times in struct utmp.
>
Indeed, my mistake (I forgot not all 64-bit time_t architecture define
__WORDSIZE_TIME64_COMPAT32). I don't have a strong opinion in fact,
at least the change should be simple somewhat (I think adding a new
paths-utmp.h included by paths.h and defined by arch ABI that requires
it).
next prev parent reply other threads:[~2020-08-05 20:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 18:59 [PATCH v2 1/7] login: Move gnu utmpx to default implementation Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 2/7] Consolidate and simplify internal utmp definitions Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 3/7] support: Add 'touch' command Adhemerval Zanella
2020-08-05 19:08 ` DJ Delorie
2020-08-05 18:59 ` [PATCH v2 4/7] login: Add 64-bit time support to utmp/utmpx Adhemerval Zanella
2020-08-05 19:28 ` Joseph Myers
2020-08-05 20:35 ` Adhemerval Zanella
2020-08-05 20:43 ` Joseph Myers
2020-08-05 20:54 ` Adhemerval Zanella [this message]
2020-08-05 18:59 ` [PATCH v2 5/7] linux: Add pwrite64_nocancel Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 6/7] login: Use 64-bit time on struct lastlog Adhemerval Zanella
2020-08-05 19:56 ` Florian Weimer
2020-08-05 20:36 ` Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 7/7] Remove __WORDSIZE_TIME64_COMPAT32 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69053e9f-6961-2672-088b-26f391b1a714@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).