From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dormouse.elm.relay.mailchannels.net (dormouse.elm.relay.mailchannels.net [23.83.212.50]) by sourceware.org (Postfix) with ESMTPS id 8836238582B1 for ; Thu, 23 Jun 2022 14:27:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8836238582B1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EE47322BA2; Thu, 23 Jun 2022 14:27:05 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 53E4622B76; Thu, 23 Jun 2022 14:27:05 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1655994425; a=rsa-sha256; cv=none; b=UN9Yl+mvZQ+4BaaMG8K1xg1au9DsjaSTVSG9LsNXTT7gXn+q6RfiptnbS08cxsqP4KP/SR 3YfbHfio0wBBUiO3875jkvKW32Ol65BkZhqoxL1X3UJwGizfyawNnWM/fPRGFT0/UvamSu 4t9l457cbKRkAPMgqhCyaTayRPMNOpoKiRVov++CP39ZFVxE+ZB58oCgDUb+RlTMZJ90IG Nb7Ki7t9AEmN6OadGOLZtfE8tKViNsQnmvZR2YShJod99tYYhx5luTiHkDMJ68KQGDPwVM kvHQtIQrLF0HjO+TXCi/nQQ1dkt5kQ0G4IB/zK/NVpqm/tvtJKUjMi33bXhcZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1655994425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d7EZC1uRbeKNCs68AgRzJvWX5GnTkO7ey+dhrp2yZeg=; b=JXoDUa7NPo7b56uF+O1kj37oxvsUaVzUcujQ4vQZaQ7u06Go4ObhdXNbnUo7lm+7rYEvNn b0sy4NJaBxzp5mQZ+aKUXfLYKejPT2Xqruy5pHWwZpio8lw7cNiGDdxf2I57IgAUWmiqIO tA9Fz21aPZ+oH2UBsNlLvOBYM0Ek+kqSTvQgOk38atuC8jV1tkGSLH/IgdmwAcDfbO6dqG KePG50dKFWb1fuYttD/9asHZqzyg+Tm8XkGw+W8NKWoId47foZaz/vJw9a7n2RHXzKtzKU qMxymoVZsDH57Sx0UiiEEciHgJKDlv6+hzhvvNpUZ+jcTT7/irGXW444RcQkYg== ARC-Authentication-Results: i=1; rspamd-786f5898df-fkjhl; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Name-Wipe: 5df7309e3461775e_1655994425597_2767574491 X-MC-Loop-Signature: 1655994425597:506989958 X-MC-Ingress-Time: 1655994425597 Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.38.187 (trex/6.7.1); Thu, 23 Jun 2022 14:27:05 +0000 Received: from [192.168.86.152] (unknown [103.199.173.0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4LTMyb5yntz31; Thu, 23 Jun 2022 07:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1655994425; bh=d7EZC1uRbeKNCs68AgRzJvWX5GnTkO7ey+dhrp2yZeg=; h=Date:Subject:From:To:Content-Type:Content-Transfer-Encoding; b=OGRC14f7QhMx+SPKuAUBd+lLVmOg7Emxl/RZ0H8QJJVtB+dT8sRoY6CzcdmntAueT l6wBVe6U9L95NPfMxdWY4x38yV8//X12MVQPKXoyKZ2qAEPD0C8X45pKVqQSKRL5Jv RiyqZURz9sNzUFnOAoAp6+hXEAm7JOj9D5Z5F0mrokIkkxP4S3ZxKAmzBWW/W6LnZo 0MFlLVLvl65FdyKxoUxZ/il0hsrZ3GB/8zyCHZAr1fpY1zLSqan/LRkzD1eiiH9Ob4 l4TkzSzNRExO3fc/tN8ODdjohwwAxoWAMKUcyDurd/sR6c+sUo5Mzv7FRSlrQr73y1 nhVGVcdop9Afw== Message-ID: <69597807-72d3-d457-d5a1-e1cb964dd99c@gotplt.org> Date: Thu, 23 Jun 2022 19:56:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1] stdlib: Fixup mbstowcs NULL __dst handling. Content-Language: en-US From: Siddhesh Poyarekar To: Noah Goldstein , libc-alpha@sourceware.org References: <20220622233442.2777550-1-goldstein.w.n@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 14:27:11 -0000 On 23/06/2022 11:16, Siddhesh Poyarekar wrote: > On 23/06/2022 05:04, Noah Goldstein via Libc-alpha wrote: >> commit 464d189b9622932a75302290625de84931656ec0 (origin/master, >> origin/HEAD) >> Author: Noah Goldstein >> Date:   Wed Jun 22 08:24:21 2022 -0700 >> >>      stdlib: Remove attr_write from mbstows if dst is NULL [BZ: 29265] >> >> Incorrectly called `__mbstowcs_chk` in the NULL __dst case which is >> incorrect as in the NULL __dst case we are explicitly skipping >> the objsize checks. >> >> As well, remove the `__always_inline` attribute which exists in >> `__fortify_function`. >> --- >>   stdlib/bits/stdlib.h | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) > > LGTM. > > Reviewed-by: Siddhesh Poyarekar Please add a reference to bz #29279 in the commit log when you push this. Sid