From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup
Date: Tue, 5 Jul 2022 09:39:36 -0300 [thread overview]
Message-ID: <697DC8B1-4F33-40E2-A40D-80251B3E1125@linaro.org> (raw)
In-Reply-To: <87pmik59ig.fsf@oldenburg.str.redhat.com>
> On 5 Jul 2022, at 04:00, Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote:
>
> NODELETE status is propagated from the referencing object to the
> referenced object, not the other way round. The code is correct, only
> the log message has the wrong direction.
>
> Tested on i686-linux-gnu and x86_64-linux-gnu.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> elf/dl-lookup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
> index 8cb32321da..4c86dc694e 100644
> --- a/elf/dl-lookup.c
> +++ b/elf/dl-lookup.c
> @@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, struct link_map *map, int flags)
> {
> if (undef_map->l_name[0] == '\0')
> _dl_debug_printf ("\
> -marking %s [%lu] as NODELETE due to reference to main program\n",
> +marking %s [%lu] as NODELETE due to reference from main program\n",
> map->l_name, map->l_ns);
> else
> _dl_debug_printf ("\
> -marking %s [%lu] as NODELETE due to reference to %s [%lu]\n",
> +marking %s [%lu] as NODELETE due to reference from %s [%lu]\n",
> map->l_name, map->l_ns,
> undef_map->l_name, undef_map->l_ns);
> }
>
prev parent reply other threads:[~2022-07-05 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 7:00 Florian Weimer
2022-07-05 12:39 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697DC8B1-4F33-40E2-A40D-80251B3E1125@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).