From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by sourceware.org (Postfix) with ESMTPS id 0299A3857433 for ; Tue, 5 Jul 2022 12:39:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0299A3857433 Received: by mail-ua1-x92d.google.com with SMTP id u41so2402292uau.8 for ; Tue, 05 Jul 2022 05:39:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xnxX8w5l0EQbbsazxeymQK/1Ob/Q5UvTS/dkGQZm1i0=; b=phvQMV1ThfF8PBhiwW77hQxUvzqxa6Z/0hz+EsXqPkFFz2zQ9B4qxreI12c4TqWAR1 KwCG4OqD4wb3MNAeTMshNxxpy87wKiH5hJi0/B83uwHwkM2V8lb9aA19gYN/AECWIE9l RHHhHIvQMxdMhVp48VHe+h5h1TrbxeNRrrldAnP655Wz9sVAMhuI8bdsdReLt7uEcm/C 9ZLhOgYw2OcnFoX+U3WrxiJ6O2avGZnu7FhrUlzsE7yKhaVYHwh9E8Khelj7vq0mE8hK DCYmSh/1LjSmuRzb5K0kNK1+XLXu2qjxVudfOMKIg4DLTo2+ZcBjxEO+uszN6O2m36Rf G7OA== X-Gm-Message-State: AJIora/20Jg4/yxtpF2K+j2KG2mtbUbaJyouDRoHhy2AYiiOFu496GDt RG2Zx825iXn26Cr07jF07eD/cMHkrAs1n8c5 X-Google-Smtp-Source: AGRyM1sMyYT3ATgu1VeoV9zZRFI/fHpxlZ9Kpdr1DILTnCUS6yJUc6l+8FNjh06UAx/GfZvotlbn+w== X-Received: by 2002:ab0:6704:0:b0:37c:c743:eebe with SMTP id q4-20020ab06704000000b0037cc743eebemr15648714uam.84.1657024778375; Tue, 05 Jul 2022 05:39:38 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7cb:fef6:fc57:dc88:c1a6:22c5]) by smtp.gmail.com with ESMTPSA id y13-20020ac5cf0d000000b0036c07e60a24sm7664087vke.45.2022.07.05.05.39.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jul 2022 05:39:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup From: Adhemerval Zanella In-Reply-To: <87pmik59ig.fsf@oldenburg.str.redhat.com> Date: Tue, 5 Jul 2022 09:39:36 -0300 Cc: libc-alpha@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <697DC8B1-4F33-40E2-A40D-80251B3E1125@linaro.org> References: <87pmik59ig.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 12:39:41 -0000 > On 5 Jul 2022, at 04:00, Florian Weimer via Libc-alpha = wrote: >=20 > NODELETE status is propagated from the referencing object to the > referenced object, not the other way round. The code is correct, only > the log message has the wrong direction. >=20 > Tested on i686-linux-gnu and x86_64-linux-gnu. LGTM, thanks. Reviewed-by: Adhemerval Zanella >=20 > --- > elf/dl-lookup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c > index 8cb32321da..4c86dc694e 100644 > --- a/elf/dl-lookup.c > +++ b/elf/dl-lookup.c > @@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, = struct link_map *map, int flags) > { > if (undef_map->l_name[0] =3D=3D '\0') > _dl_debug_printf ("\ > -marking %s [%lu] as NODELETE due to reference to main program\n", > +marking %s [%lu] as NODELETE due to reference from main program\n", > map->l_name, map->l_ns); > else > _dl_debug_printf ("\ > -marking %s [%lu] as NODELETE due to reference to %s [%lu]\n", > +marking %s [%lu] as NODELETE due to reference from %s [%lu]\n", > map->l_name, map->l_ns, > undef_map->l_name, undef_map->l_ns); > } >=20