From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, Frederic Berat <fberat@redhat.com>
Subject: Re: [PATCH] scripts: Fix fortify checks if compiler does not support _FORTIFY_SOURCE=3
Date: Thu, 20 Jul 2023 18:46:56 +0200 [thread overview]
Message-ID: <6990540.G0QQBjFxQf@kona> (raw)
In-Reply-To: <87jzuumtv6.fsf@oldenburg.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Am Donnerstag, 20. Juli 2023, 18:26:53 CEST schrieb Florian Weimer:
> * Siddhesh Poyarekar:
>
> > On 2023-07-20 10:40, Adhemerval Zanella via Libc-alpha wrote:
> >> The 30379efad1 added _FORTIFY_SOURCE checks without check if compiler
> >> does support all used fortify levels. This patch fixes it by first
> >> checking at configure time the maximum support fortify level and using
> >> it instead of a pre-defined one.
> >> Checked on x86_64 with gcc 11, 12, and 13.
> >> ---
> >
> > LGTM, pending approval from RM. At the moment there's no real reason
> > to verify headers for different fortification levels (just 1 or 2
> > would do) but I reckon it's a future-proof change, in case we ever end
> > up diverging further on those levels.
> >
> > Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> Agreed, and (with GCC 11):
>
> Tested-by: Florian Weimer <fweimer@redhat.com>
>
OK let's go with it. Thanks! -a
--
PD Dr. Andreas K. Huettel
Institute for Experimental and Applied Physics
University of Regensburg
93040 Regensburg
Germany
tel. +49 151 241 67748 (mobile)
tel. +49 941 943 1618 (office)
e-mail andreas.huettel@ur.de
https://www.akhuettel.de/
https://www.akhuettel.de/group/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
prev parent reply other threads:[~2023-07-20 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:40 Adhemerval Zanella
2023-07-20 16:22 ` Siddhesh Poyarekar
2023-07-20 16:26 ` Florian Weimer
2023-07-20 16:46 ` Andreas K. Huettel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6990540.G0QQBjFxQf@kona \
--to=dilfridge@gentoo.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fberat@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).