From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96026 invoked by alias); 26 Oct 2016 21:01:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96012 invoked by uid 89); 26 Oct 2016 21:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=recommended X-HELO: mailapp01.imgtec.com From: Matthew Fortune To: Joseph Myers CC: "libc-alpha@sourceware.org" , "Sandra Loosemore (sandra@codesourcery.com)" , "Petar Jovanovic" Subject: RE: [PATCH] Initialise the machine specific part of rtld bootstrap map Date: Wed, 26 Oct 2016 21:01:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B0235380AAC147@HHMAIL01.hh.imgtec.org> References: <6D39441BF12EF246A7ABCE6654B0235380AABFF9@HHMAIL01.hh.imgtec.org> In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2016-10/txt/msg00479.txt.bz2 Joseph Myers writes: > On Wed, 26 Oct 2016, Matthew Fortune wrote: >=20 > > +# ifdef ELF_MACHINE_INIT_MAP > > + ELF_MACHINE_INIT_MAP (bootstrap_map); # endif >=20 > We don't encourage use of #ifdef like that. It's better to have an > inline function defined everywhere and used unconditionally, for which > most systems have a dummy definition (see dl-machine-reject-phdr.h and > elf_machine_reject_phdr_p for an example - if you have a header for a > single function, you don't need to update lots of dl-machine.h headers, > just add a generic version - which has the comments detailing the > semantics of the function and when it's needed - and a MIPS version). Thanks Joseph. It's been a while since I did a glibc patch and couldn't remember the recommended approach. Do you think I should add a whole new header for this? Or, since this is directly related to the reject_phdr feature for MIPS and only MIPS is affected then I could just add it to dl-machine-reject-phdr.h? Matthew