From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by sourceware.org (Postfix) with ESMTPS id 754243839C70 for ; Thu, 22 Jul 2021 08:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 754243839C70 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=physik.fu-berlin.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zedat.fu-berlin.de Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.94) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1m6U4C-003fv3-3Q; Thu, 22 Jul 2021 10:28:28 +0200 Received: from ip5b40345f.dynamic.kabel-deutschland.de ([91.64.52.95] helo=[192.168.178.58]) by inpost2.zedat.fu-berlin.de (Exim 4.94) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1m6U4B-000tNb-TI; Thu, 22 Jul 2021 10:28:28 +0200 Subject: Re: [PATCH v3 0/7] Fix getdents{64} regression on some FS To: Adhemerval Zanella , libc-alpha@sourceware.org, Florian Weimer Cc: Dave Flogeras , James Clarke References: <20201021141542.2003377-1-adhemerval.zanella@linaro.org> From: John Paul Adrian Glaubitz Message-ID: <6a2e134a-2a35-0834-f1fa-7b30ac9efb11@physik.fu-berlin.de> Date: Thu, 22 Jul 2021 10:28:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20201021141542.2003377-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.64.52.95 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2021 08:28:39 -0000 Hi! On 10/21/20 4:15 PM, Adhemerval Zanella wrote: > This is updated version [1], rebased against master add with some > suggestion from previous review. The main changes are: > > - The translation buffer is allocated as an auxiliarry one (instead > of a reserved spacefrom the dirstream) and readdir might reallocate > it if it finds a large entry. > > - Failures in non-LFS readdir (such as d_ino/d_off overflow or failure > in expand the translation buffer) is ignored. This allows code that > does not handle possible failure in readdir to successful read the > rest of entries in the directory. > > - So minor fixes in dirent/tst-seekdir2.c > > - Added __attribute_deprecated_msg__ on getdirentries to redirect to > getdents64. > > I have checked on x86_64-linux-gnu, powerpc64-linux-gnu and on some > 32-bit ABIs arm-linux-gnueabihf, powerpc-linux-gnu, and sparcv9-linux-gnu. Are there any news on this patch series? The bug is still present as far as I know. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913