From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Subject: [PATCH 2/4] powerpc64le: refactor e_sqrtf128.c
Date: Mon, 4 May 2020 17:23:51 -0500 [thread overview]
Message-ID: <6a73737db700dca0aea859a34e1df95a42d25b28.1588628261.git.murphyp@linux.vnet.ibm.com> (raw)
In-Reply-To: <e3158cb2e97968716d0bdb75ff0d0b8f0c51c299.1588628261.git.murphyp@linux.vnet.ibm.com>
Combine both implementations into a single file to allow
building twice with appropriate multiarch support when possible.
Likewise, this maintains the existing optimal behavior when
building with a power9 or newer cpu.
---
sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c | 8 +++-
.../powerpc64/le/power9/fpu/e_sqrtf128.c | 38 -------------------
2 files changed, 7 insertions(+), 39 deletions(-)
delete mode 100644 sysdeps/powerpc/powerpc64/le/power9/fpu/e_sqrtf128.c
diff --git a/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c b/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
index 950bdad54a..fac8def02a 100644
--- a/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
+++ b/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
@@ -26,6 +26,7 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include <float128_private.h>
#include <math.h>
#include <libm-alias-finite.h>
@@ -42,16 +43,21 @@
__float128
__ieee754_sqrtf128 (__float128 a)
{
+ __float128 r;
+ /* For multiarch builds, this will be built twice. */
+#ifndef _ARCH_PWR9
FP_DECL_EX;
FP_DECL_Q (A);
FP_DECL_Q (R);
- __float128 r;
FP_INIT_ROUNDMODE;
FP_UNPACK_Q (A, a);
FP_SQRT_Q (R, A);
FP_PACK_Q (r, R);
FP_HANDLE_EXCEPTIONS;
+#else
+ asm ("xssqrtqp %0,%1" : "=v" (r) : "v" (a));
+#endif
return r;
}
libm_alias_finite (__ieee754_sqrtf128, __sqrtf128)
diff --git a/sysdeps/powerpc/powerpc64/le/power9/fpu/e_sqrtf128.c b/sysdeps/powerpc/powerpc64/le/power9/fpu/e_sqrtf128.c
deleted file mode 100644
index 232fc773c3..0000000000
--- a/sysdeps/powerpc/powerpc64/le/power9/fpu/e_sqrtf128.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/* POWER9 sqrt for _Float128
- Return sqrt(a)
- Copyright (C) 2017-2020 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- In addition to the permissions in the GNU Lesser General Public
- License, the Free Software Foundation gives you unlimited
- permission to link the compiled version of this file into
- combinations with other programs, and to distribute those
- combinations without any restriction coming from the use of this
- file. (The Lesser General Public License restrictions do apply in
- other respects; for example, they cover modification of the file,
- and distribution when not linked into a combine executable.)
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <libm-alias-finite.h>
-
-__float128
-__ieee754_sqrtf128 (__float128 a)
-{
- __float128 z;
- asm ("xssqrtqp %0,%1" : "=v" (z) : "v" (a));
- return z;
-}
-libm_alias_finite (__ieee754_sqrtf128, __sqrtf128)
--
2.21.1
next prev parent reply other threads:[~2020-05-04 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 22:23 [PATCH 1/4] ldbl-128: refactor nexttoward alias using new macro Paul E. Murphy
2020-05-04 22:23 ` Paul E. Murphy [this message]
2020-05-04 22:23 ` [PATCH 3/4] powerpc64le: refactor fmaf128 Paul E. Murphy
2020-05-04 22:23 ` [PATCH 4/4] powerpc64le: ifunc (almost) all *f128 routines in multiarch mode Paul E. Murphy
2020-05-05 0:07 ` Joseph Myers
2020-05-05 7:07 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a73737db700dca0aea859a34e1df95a42d25b28.1588628261.git.murphyp@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).