From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id B8EF73857C68 for ; Wed, 24 Mar 2021 12:40:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8EF73857C68 Received: by mail-qv1-xf2c.google.com with SMTP id x27so12155343qvd.2 for ; Wed, 24 Mar 2021 05:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XNf1RPXsJOMza+1EhLIxDOZOVcp/vg9YVV7qud+AN20=; b=RZP+31fnT1kmrrDJMf2HN6TYQT2DLJaPPY24ebLkGyp+dQZX392EuHQg6c+05S60gx EP8cVJ/FbLqOkIrndwssxBcyXeBdaZCkyL9PHXFbobtmpn+yztZQzYdwFHECbRvcgY/4 u/GtyJX6Pun5l73yDBUMmT7nNkR12TKnMD61YAm/pPN2AxcmYezoZeX/ZN89F/lyiQD2 GRkli5R7KsHCDOigkfBLufzhQnJI7EWz2/K/glCerjRuAMHsbGnGXG1WZgY0+qt28/i5 AyXG7G5wQFmEjj9dhtJ/69s9R1T10GeaMYOwrt/DuDbV/JwihQSzfRTqnsm/C3Jf7pmt lHbw== X-Gm-Message-State: AOAM533LP4dPH61Hx1S0WzE3jwyuSyzOFY+Ksd8ZeePH4kY6wJql4vjI wx1eMDA8iBtFYoiGA9eUcmytr/moFk26YQ== X-Google-Smtp-Source: ABdhPJwKEerHIkPgIcPyg99anx0CGdODOHXCTKymjtOuiZwgcoSD7BAbKrkhap3zzLjOAMKPKD01NA== X-Received: by 2002:a0c:8ec1:: with SMTP id y1mr2822965qvb.11.1616589639217; Wed, 24 Mar 2021 05:40:39 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id q65sm1593808qkb.51.2021.03.24.05.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 05:40:38 -0700 (PDT) Subject: Re: [hurd,commited] htl: Add missing fork.h To: Samuel Thibault Cc: libc-alpha@sourceware.org References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> <20210324123136.x5ab7fkrcm557enm@begin> From: Adhemerval Zanella Message-ID: <6aa8826c-b8ab-d999-4b99-e61c27282587@linaro.org> Date: Wed, 24 Mar 2021 09:40:36 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324123136.x5ab7fkrcm557enm@begin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 12:40:41 -0000 On 24/03/2021 09:31, Samuel Thibault wrote: > Adhemerval Zanella, le mer. 24 mars 2021 09:29:44 -0300, a ecrit: >> On 23/03/2021 21:20, Samuel Thibault wrote: >>> 2b47727c68b6 ("posix: Consolidate register-atfork") introduced a fork.h >>> header to declare the atfork unregister hook, but was missing adding it >>> for htl. >>> >>> This fixes tst-atfork2. >> >> Both lowlevellock.h and register-atfork.h are common headers, >> I think it would be better to just add them to generic fork.h header. > > Ok but perhaps there was a reason why you didn't do it in your commit? I haven't touched the generic fork.h because I haven't see build issues on i686-gnu. Why exactly tst-atfork2 fails without this includes?